Skip to content

Conversation

@adinauer
Copy link
Member

@adinauer adinauer commented May 8, 2025

#skip-changelog

📜 Description

Use a separate ExecutorService for log batching

💡 Motivation and Context

Avoid using the executor service on options for specific features too much.

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 0d007b2

Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@adinauer adinauer changed the title Use a separate ExecutorService for log batching [Logs 5] Use a separate ExecutorService for log batching May 12, 2025
Base automatically changed from feat/log-batching to main May 13, 2025 13:13
@github-actions
Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 404.18 ms 475.22 ms 71.04 ms
Size 1.58 MiB 2.08 MiB 509.50 KiB

@adinauer adinauer merged commit defba33 into main May 13, 2025
34 checks passed
@adinauer adinauer deleted the feat/log-batching-separate-executor-service branch May 13, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants