Skip to content

Conversation

@adinauer
Copy link
Member

📜 Description

Use SPI to search for other ContextStorageProviders and wrap them instead of using SentryOtelThreadLocalStorage

💡 Motivation and Context

Closes #4339

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Apr 25, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against a9ea643

@github-actions
Copy link
Contributor

github-actions bot commented Apr 25, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 404.55 ms 438.12 ms 33.57 ms
Size 1.58 MiB 2.08 MiB 507.51 KiB

Previous results on branch: feat/wrap-existing-otel-storage-provider

Startup times

Revision Plain With Sentry Diff
ae36667 407.87 ms 427.90 ms 20.03 ms

App size

Revision Plain With Sentry Diff
ae36667 1.58 MiB 2.08 MiB 507.28 KiB

Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, LGTM 👍

@adinauer adinauer merged commit 1d7823d into main Apr 25, 2025
38 checks passed
@adinauer adinauer deleted the feat/wrap-existing-otel-storage-provider branch April 25, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integrate Sentry OTel with External Context Storage Providers

4 participants