Skip to content

Conversation

@stefanosiano
Copy link
Contributor

📜 Description

update rate limiting and client reports for profile chunks from profile_chunk to profile_chunk_ui

💡 Motivation and Context

Rate limiting is different for UI and backend profiling, so they have different keys

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

  • sentry/src/main/java/io/sentry/transport/RateLimiter.java

@stefanosiano stefanosiano marked this pull request as ready for review April 23, 2025 14:31
@github-actions
Copy link
Contributor

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

  • sentry/src/main/java/io/sentry/transport/RateLimiter.java

@github-actions
Copy link
Contributor

github-actions bot commented Apr 23, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 438.21 ms 500.31 ms 62.10 ms
Size 1.58 MiB 2.08 MiB 507.28 KiB

Previous results on branch: fix/update-profile-chunk-category

Startup times

Revision Plain With Sentry Diff
2415e79 456.06 ms 519.55 ms 63.49 ms

App size

Revision Plain With Sentry Diff
2415e79 1.58 MiB 2.08 MiB 507.28 KiB

@github-actions
Copy link
Contributor

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

  • sentry/src/main/java/io/sentry/transport/RateLimiter.java

Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stefanosiano stefanosiano merged commit 6df3ba5 into main Apr 24, 2025
39 checks passed
@stefanosiano stefanosiano deleted the fix/update-profile-chunk-category branch April 24, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants