Skip to content

Conversation

@adinauer
Copy link
Member

📜 Description

Wrap Runnable for usage with Sentry, e.g. when using virtual threads

💡 Motivation and Context

Closes #4328

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Apr 14, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 49a0f84

@github-actions
Copy link
Contributor

github-actions bot commented Apr 14, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 417.22 ms 480.48 ms 63.26 ms
Size 1.58 MiB 2.08 MiB 505.69 KiB

Previous results on branch: feat/wrap-runnable

Startup times

Revision Plain With Sentry Diff
c6f165a 396.41 ms 444.37 ms 47.95 ms
356dc21 399.31 ms 446.02 ms 46.71 ms

App size

Revision Plain With Sentry Diff
c6f165a 1.58 MiB 2.08 MiB 505.88 KiB
356dc21 1.58 MiB 2.08 MiB 505.66 KiB

Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! If feasible, a test would be nice as well, ensuring scope modifications are contained within the runnable.

@adinauer adinauer merged commit 084562d into main Apr 15, 2025
35 checks passed
@adinauer adinauer deleted the feat/wrap-runnable branch April 15, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for Sentry context propagation in Java Virtual Threads

3 participants