Skip to content

Conversation

@adinauer
Copy link
Member

📜 Description

This mostly affects sentry-opentelemetry-agent as it used to have a complex version string in the Implementation-Version attribute of its MANIFEST.MF (e.g. sentry-8.5.0-otel-2.10.0). We now use the Sentry-Version-Name attribute for the complex version instead and keep Implementation-Version simple, e.g. 8.5.0.

💡 Motivation and Context

Implementation-Version is a common attribute and we should try to keep it simple. Also see https://docs.oracle.com/javase/tutorial/deployment/jar/packageman.html

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Mar 27, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 11cb785

Copy link
Member

@lcian lcian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, so now Implementation-Version will be the release name right?
e.g. 8.0.0-rc1

@adinauer
Copy link
Member Author

Makes sense, so now Implementation-Version will be the release name right?
e.g. 8.0.0-rc1

Yes exactly, since this is a commonly used attribute in MANIFEST.MF IMO it makes more sense to keep this as a simple value.

@lcian
Copy link
Member

lcian commented Mar 27, 2025

Makes sense, so now Implementation-Version will be the release name right?
e.g. 8.0.0-rc1

Yes exactly, since this is a commonly used attribute in MANIFEST.MF IMO it makes more sense to keep this as a simple value.

Yeah I agree!

Base automatically changed from feat/fatal-logger to main March 27, 2025 13:38
@github-actions
Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 451.00 ms 463.09 ms 12.09 ms
Size 1.58 MiB 2.22 MiB 655.16 KiB

@adinauer adinauer merged commit ce3873d into main Mar 27, 2025
35 checks passed
@adinauer adinauer deleted the feat/manifest-version-attributes branch March 27, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants