-
-
Notifications
You must be signed in to change notification settings - Fork 465
Use Implementation-Version as raw version
#4291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…-versions-android
|
lcian
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, so now Implementation-Version will be the release name right?
e.g. 8.0.0-rc1
Yes exactly, since this is a commonly used attribute in |
Yeah I agree! |
Performance metrics 🚀
|
📜 Description
This mostly affects
sentry-opentelemetry-agentas it used to have a complex version string in theImplementation-Versionattribute of itsMANIFEST.MF(e.g.sentry-8.5.0-otel-2.10.0). We now use theSentry-Version-Nameattribute for the complex version instead and keepImplementation-Versionsimple, e.g.8.5.0.💡 Motivation and Context
Implementation-Versionis a common attribute and we should try to keep it simple. Also see https://docs.oracle.com/javase/tutorial/deployment/jar/packageman.html💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps