Fix tags missing for compose view hierarchies #4275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markushi
requested review from
adinauer,
lcian,
romtsn and
stefanosiano
as code owners
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| eb39954 | 436.12 ms | 493.80 ms | 57.68 ms |
| f63778b | 413.88 ms | 482.02 ms | 68.14 ms |
| 6f1848f | 384.70 ms | 441.52 ms | 56.82 ms |
| ec2f9cd | 390.96 ms | 418.91 ms | 27.95 ms |
| 261e725 | 389.22 ms | 417.14 ms | 27.92 ms |
| b159a6d | 378.41 ms | 464.32 ms | 85.91 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| eb39954 | 1.58 MiB | 2.22 MiB | 652.89 KiB |
| f63778b | 1.58 MiB | 2.22 MiB | 652.84 KiB |
| 6f1848f | 1.58 MiB | 2.22 MiB | 652.90 KiB |
| ec2f9cd | 1.58 MiB | 2.22 MiB | 655.17 KiB |
| 261e725 | 1.58 MiB | 2.22 MiB | 655.17 KiB |
| b159a6d | 1.58 MiB | 2.22 MiB | 653.07 KiB |
romtsn
reviewed
Mar 21, 2025
...-compose-helper/src/jvmMain/java/io/sentry/compose/gestures/ComposeGestureTargetLocator.java
Outdated
Show resolved
Hide resolved
romtsn
reviewed
Mar 21, 2025
...-compose-helper/src/jvmMain/java/io/sentry/compose/gestures/ComposeGestureTargetLocator.java
Outdated
Show resolved
Hide resolved
romtsn
reviewed
Mar 21, 2025
| } | ||
| } | ||
| } | ||
| } else if ("androidx.compose.ui.platform.TestTagElement".equals(type) |
Member
There was a problem hiding this comment.
is it possible to test it with robolectric/instrumented tests to avoid regressions in future?
romtsn
approved these changes
Mar 21, 2025
Member
romtsn
left a comment
romtsn
left a comment
There was a problem hiding this comment.
would be nice to have tests for this (and extract that logic into a separate class if possible), but LGTM otherwise!
….com:getsentry/sentry-java into markushi/fix/compose-view-hierarchy-exporter
tipapro
reviewed
Mar 24, 2025
sentry-compose-helper/src/jvmMain/java/io/sentry/compose/SentryComposeHelper.java
Outdated
Show resolved
Hide resolved
romtsn
reviewed
Mar 26, 2025
| return value as String? | ||
| } | ||
| } catch (e: Throwable) { | ||
| // ignored |
Member
There was a problem hiding this comment.
maybe worth to add a debug log here so we can troubleshoot easier?
romtsn
reviewed
Mar 26, 2025
sentry-compose/src/androidMain/kotlin/io/sentry/compose/SentryComposeHelper.kt
Outdated
Show resolved
Hide resolved
romtsn
reviewed
Mar 26, 2025
...c/androidUnitTest/kotlin/io/sentry/compose/viewhierarchy/ComposeViewHierarchyExporterTest.kt
Outdated
Show resolved
Hide resolved
romtsn
reviewed
Mar 26, 2025
...mpose/src/androidMain/kotlin/io/sentry/compose/viewhierarchy/ComposeViewHierarchyExporter.kt
Outdated
Show resolved
Hide resolved
romtsn
reviewed
Mar 26, 2025
...mpose/src/androidMain/kotlin/io/sentry/compose/viewhierarchy/ComposeViewHierarchyExporter.kt
Outdated
Show resolved
Hide resolved
romtsn
approved these changes
Mar 26, 2025
Member
romtsn
left a comment
romtsn
left a comment
There was a problem hiding this comment.
LGTM again, but these two comments I guess would be nice to address: https://github.com/getsentry/sentry-java/pull/4275/files#r2014326540
Great tests btw, and very happy to get rid of that workaround with the java-only module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Only on newer versions of Jetpack Compose
💡 Motivation and Context
Fixes #4273
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps