-
-
Notifications
You must be signed in to change notification settings - Fork 465
Pass OpenTelemetry span attributes into TracesSampler callback #4253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Performance metrics 🚀
|
lcian
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some minor nits but LGTM.
We are calling it getAttribute which could possibly be an API we will have on Span as part of the attributes API that is in the works. As far as I understand this new concept of attributes will correspond to the OTEL one we are using here, so I agree on this naming.
Let's not forget to update the relevant docs: https://docs.sentry.io/platforms/java/guides/spring-boot/configuration/sampling/#setting-a-sampling-function
...telemetry/sentry-opentelemetry-core/src/main/java/io/sentry/opentelemetry/SentrySampler.java
Show resolved
Hide resolved
Co-authored-by: Lorenzo Cian <lorenzo.cian@sentry.io>
📜 Description
SamplingContextnow has agetAttributemethod granting access to OpenTelemetry span attributes when Sentry is used in OpenTelemetry mode.💡 Motivation and Context
Fixes #4192
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps