Skip to content

Conversation

@adinauer
Copy link
Member

@adinauer adinauer commented Mar 6, 2025

#skip-changelog

📜 Description

Adds tracing endpoints to more server modules and tests for it as well.

💡 Motivation and Context

More system test coverage -> less manual testing when changing anything on distributed tracing

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 6dbc24b

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 427.87 ms 490.38 ms 62.50 ms
Size 1.58 MiB 2.21 MiB 641.83 KiB

Baseline results on branch: feat/reuse-test-support-for-system-tests

Startup times

Revision Plain With Sentry Diff
3b5ce95 381.59 ms 427.42 ms 45.83 ms
0d3c536 401.91 ms 404.49 ms 2.58 ms

App size

Revision Plain With Sentry Diff
3b5ce95 1.58 MiB 2.21 MiB 641.82 KiB
0d3c536 1.58 MiB 2.21 MiB 641.83 KiB

Copy link
Member

@lcian lcian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Base automatically changed from feat/reuse-test-support-for-system-tests to main March 11, 2025 09:56
@adinauer adinauer merged commit ac9ebcd into main Mar 11, 2025
33 of 35 checks passed
@adinauer adinauer deleted the feat/add-distributed-tracing-system-tests-to-more-modules branch March 11, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants