Skip to content

Conversation

@adinauer
Copy link
Member

@adinauer adinauer commented Mar 5, 2025

#skip-changelog

📜 Description

We now run tests that assert distributed tracing by having a Spring boot server call into itself via HTTP

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 1dd3ea4

@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 445.02 ms 483.76 ms 38.74 ms
Size 1.58 MiB 2.21 MiB 642.21 KiB

Previous results on branch: feat/distributed-tracing-system-tests

Startup times

Revision Plain With Sentry Diff
a75dbee 369.13 ms 428.11 ms 58.98 ms

App size

Revision Plain With Sentry Diff
a75dbee 1.58 MiB 2.21 MiB 641.82 KiB

Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

Base automatically changed from feat/add-run-build-param-to-test-run-script to main March 11, 2025 09:19
@adinauer adinauer merged commit a2c3d69 into main Mar 11, 2025
33 of 35 checks passed
@adinauer adinauer deleted the feat/distributed-tracing-system-tests branch March 11, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants