Skip to content

Conversation

@markushi
Copy link
Member

📜 Description

This is the custom user-defined name device name (e.g. "Markus Pixel Device"), I don't see any good reason why we would collect this, even if PII collecting is enabled.

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Feb 18, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 377.09 ms 469.82 ms 92.73 ms
Size 1.58 MiB 2.21 MiB 646.60 KiB

Previous results on branch: markushi/feat/drop-device-name

Startup times

Revision Plain With Sentry Diff
fdc6fc1 408.96 ms 518.10 ms 109.14 ms

App size

Revision Plain With Sentry Diff
fdc6fc1 1.58 MiB 2.21 MiB 640.88 KiB

@markushi markushi enabled auto-merge (squash) February 26, 2025 11:11
@markushi markushi disabled auto-merge February 26, 2025 11:12
@markushi markushi merged commit 70c11a0 into main Mar 17, 2025
35 checks passed
@markushi markushi deleted the markushi/feat/drop-device-name branch March 17, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants