Skip to content

Fix ActivityLifecycleSpanHelperTest by resetting AppStartMetrics #4038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adinauer merged 2 commits into from
Jan 10, 2025
Merged

Fix ActivityLifecycleSpanHelperTest by resetting AppStartMetrics #4038

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd3dd12
fix test
adinauer Jan 10, 2025
4cb6851
Only initialize CodeQl for Java
markushi Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/codeql-analysis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
- name: Initialize CodeQL
uses: github/codeql-action/init@df409f7d9260372bd5f19e5b04e83cb3c43714ae # pin@v2
with:
languages: ${{ matrix.language }}
languages: 'java'

- name: Build Java
run: |
Expand Down
6 changes: 6 additions & 0 deletions ...-core/src/test/java/io/sentry/android/core/performance/ActivityLifecycleSpanHelperTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import org.mockito.kotlin.mock
import org.mockito.kotlin.whenever
import java.util.Date
import java.util.concurrent.TimeUnit
import kotlin.test.BeforeTest
import kotlin.test.Test
import kotlin.test.assertEquals
import kotlin.test.assertFalse
Expand Down Expand Up @@ -48,6 +49,11 @@ class ActivityLifecycleSpanHelperTest {
}
private val fixture = Fixture()

@BeforeTest
fun setup() {
AppStartMetrics.getInstance().clear()
}

@Test
fun `createAndStopOnCreateSpan creates and finishes onCreate span`() {
val helper = fixture.getSut()
Expand Down
Loading