Modifier.sentryTag uses Modifier.Node

[richkzad]

📜 Description

Converts Modifier.sentryTag to be implemented with Modifier.Node.

fixes #4028

💡 Motivation and Context

Currently, Modifier.sentryTag prevents composable skipping, due to creating a lambda within a non-@Composable function.

Assuming the @Composable annotation cannot be added (might be a breaking change if other developers have used Modifier.sentryTag outside of a @Composable context), then a Modifier.Node implementation will help avoid recomposition.

💚 How did you test it?

I did build a UI test for this, but was unsure how to run it.

package io.sentry.uitest.android

import androidx.compose.foundation.layout.Box
import androidx.compose.ui.Modifier
import androidx.compose.ui.test.SemanticsMatcher
import androidx.compose.ui.test.junit4.createComposeRule
import androidx.test.ext.junit.runners.AndroidJUnit4
import io.sentry.compose.SentryModifier.sentryTag
import org.junit.Rule
import org.junit.Test
import org.junit.runner.RunWith

@RunWith(AndroidJUnit4::class)
class SentryModifierTest : BaseUiTest() {

    @get:Rule
    val rule = createComposeRule()

    @Test
    fun sentryModifierAppliesTag() {
        rule.setContent {
            Box(Modifier.sentryTag(testSentryTag))
        }
        rule.onNode(
            SemanticsMatcher(testSentryTag) {
                it.config.find { (key, _) -> key.name == "sentryTag" }?.value == testSentryTag
            }
        )
            .assertExists()
    }
}

private const val testSentryTag = "TestSentryTag"

📝 Checklist

• I added tests to verify the changes.
• No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
• I updated the docs if needed.
• I updated the wizard if needed.
• Review from the native team if needed.
• No breaking change or entry added to the changelog.
• No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

[markushi]

Referencing richkzad#2 here as well, so we can get this ready for merging soon.

[richkzad]

Thank you @markushi ! Merged in your changes.