-
-
Notifications
You must be signed in to change notification settings - Fork 465
Add support for async dispatch requests #3983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Keeps the transaction open until the response is committed.
adinauer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, sorry for the long wait here. I just took a quick look and the way this is implemented at the moment would break distributed tracing. I'll update the PR to fix this.
Also this is still based on v7 main, I'll update to current main.
| httpRequest.getHeader(SentryTraceHeader.SENTRY_TRACE_HEADER); | ||
| final @Nullable List<String> baggageHeader = | ||
| Collections.list(httpRequest.getHeaders(BaggageHeader.BAGGAGE_HEADER)); | ||
| final @Nullable TransactionContext transactionContext = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change would break existing functionality. We would no longer be parsing and propagating incoming tracing information or create a new trace in case there's no incoming info. This would break distributed tracing, which allows you to track execution from e.g. an App across multiple servers.
|
I've updated the PR.
I'll let someone else on the team review this, since I've changed quite a bit. You may also want to give our OpenTelemetry based SDK a try if you can't wait for this change to be released. Docs on how to setup can be found here: https://docs.sentry.io/platforms/java/guides/spring-boot/ |
sentry-spring-jakarta/src/main/java/io/sentry/spring/jakarta/tracing/SentryTracingFilter.java
Show resolved
Hide resolved
|
Ooops didn't mean to approve but just to comment. |
lcian
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
|
Thanks again for the PR @aesy, we've just released this as part of https://github.com/getsentry/sentry-java/releases/tag/8.3.0 |
|
That's great, thank you for the update! |
Keeps the transaction open until the response is committed.
Fixes #3982