Skip to content

Conversation

@lbloder
Copy link
Collaborator

@lbloder lbloder commented Nov 26, 2024

📜 Description

Support both HttpAttributes.HTTP_REQUEST_METHOD and SemanticAttributes.HTTP_METHOD as source for httpMethod.

💡 Motivation and Context

Fixes double check for HttpAttributes.HTTP_REQUEST_METHOD and adds SemanticAttributes.HTTP_METHOD.

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Nov 26, 2024

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Support HTTP_METHOD and HTTP_REQUEST_METHOD for Otel Spans ([#3930](https://github.com/getsentry/sentry-java/pull/3930))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 614e9c2

@github-actions
Copy link
Contributor

github-actions bot commented Nov 26, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 378.34 ms 419.43 ms 41.09 ms
Size 1.58 MiB 2.22 MiB 655.16 KiB

Base automatically changed from 8.x.x to main January 9, 2025 15:47
# Conflicts:
#	CHANGELOG.md
#	sentry-opentelemetry/sentry-opentelemetry-core/src/main/java/io/sentry/opentelemetry/SpanDescriptionExtractor.java
@lbloder lbloder requested a review from lcian as a code owner March 28, 2025 08:35
@lbloder
Copy link
Collaborator Author

lbloder commented Mar 28, 2025

Closed as obsolete, as we do not support SemanticAttributes.HTTP_METHOD and solely rely on HttpAttributes.HTTP_REQUEST_METHOD throughout the codebase

@lbloder lbloder closed this Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants