Fix testTag not working for gesture detection #3878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7a186fe | 370.09 ms | 375.96 ms | 5.87 ms |
| 2ec7731 | 387.58 ms | 420.28 ms | 32.70 ms |
| 6b69b83 | 417.82 ms | 430.78 ms | 12.96 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7a186fe | 1.70 MiB | 2.35 MiB | 668.44 KiB |
| 2ec7731 | 1.70 MiB | 2.35 MiB | 668.42 KiB |
| 6b69b83 | 1.70 MiB | 2.35 MiB | 669.38 KiB |
romtsn
approved these changes
Nov 14, 2024
Contributor
|
Any blockers for this getting merged? @markushi |
Member
Author
|
@audkar no blockers so far, I was just looking into ways to have this better covered by CI tests, which seems to be hard within |
markushi
added a commit
that referenced
this pull request
Dec 2, 2024
* Fix testTag not working in new versions of Jetpack Compose * Ensure field is accessible * Update changelog * Fix use getDeclaredField instead of getField
markushi
added a commit
that referenced
this pull request
Dec 2, 2024
* Switch to 3 devices (Android 11, 13, 14), Increase timeout (#3897) Co-authored-by: Stefano <stefano.siano@sentry.io> * Bump github/codeql-action from 3.27.0 to 3.27.5 (#3923) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.27.0 to 3.27.5. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@6624720...f09c1c0) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump codecov/codecov-action from 4.6.0 to 5.0.7 (#3922) Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.6.0 to 5.0.7. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@b9fd7d1...015f24e) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump gradle/actions (#3924) Bumps [gradle/actions](https://github.com/gradle/actions) from 707359876a764dbcdb9da0b0ed08291818310c3d to 4ba34e96c5f6493e99d0696180a9a8d431577ba9. - [Release notes](https://github.com/gradle/actions/releases) - [Commits](gradle/actions@7073598...4ba34e9) --- updated-dependencies: - dependency-name: gradle/actions dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump JamesIves/github-pages-deploy-action from 4.6.8 to 4.6.9 (#3868) Bumps [JamesIves/github-pages-deploy-action](https://github.com/jamesives/github-pages-deploy-action) from 4.6.8 to 4.6.9. - [Release notes](https://github.com/jamesives/github-pages-deploy-action/releases) - [Commits](JamesIves/github-pages-deploy-action@881db53...62fec3a) --- updated-dependencies: - dependency-name: JamesIves/github-pages-deploy-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: Update PR template (#3909) Remove I reviewed the code and add updating the wizard because we often forget to update it. * Fix testTag not working for Jetpack Compose gesture detection (#3878) * Fix testTag not working in new versions of Jetpack Compose * Ensure field is accessible * Update changelog * Fix use getDeclaredField instead of getField * add talk on session replay to readme (#3928) #skip-changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Stefano <stefano.siano@sentry.io> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io> Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
💡 Motivation and Context
Automatic user interaction tracking
Fixes getsentry/sentry-android-gradle-plugin#784
💚 How did you test it?
So far, only manually 😢
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps