Skip to content

Conversation

@adinauer
Copy link
Member

📜 Description

OpenTelemetry spans can have events attached. This PR allows us to capture exceptions from ExceptionEventData into Sentry if the captureOpenTelemetryEvents option is enabled.

💡 Motivation and Context

Allows us to capture more errors. Doesn't require extra Sentry dependencies on the application for capturing errors - the agent alone is enough to capture errors.

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@adinauer adinauer changed the base branch from main to 8.x.x July 11, 2024 07:42
@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against eee5b29

@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 390.00 ms 439.42 ms 49.42 ms
Size 1.58 MiB 2.21 MiB 642.21 KiB

Previous results on branch: feat/poc-capture-otel-events

Startup times

Revision Plain With Sentry Diff
eab21c9 373.65 ms 471.24 ms 97.59 ms
ec63bca 387.26 ms 503.32 ms 116.06 ms

App size

Revision Plain With Sentry Diff
eab21c9 1.58 MiB 2.21 MiB 641.59 KiB
ec63bca 1.58 MiB 2.21 MiB 641.84 KiB

Base automatically changed from 8.x.x to main January 9, 2025 15:47
@adinauer adinauer changed the title POTEL 36 - POC Capture OpenTelemetry Events Capture OpenTelemetry span events Mar 3, 2025
@adinauer adinauer marked this pull request as ready for review March 3, 2025 05:25
Copy link
Member

@lcian lcian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adinauer adinauer merged commit 033bc88 into main Mar 11, 2025
35 checks passed
@adinauer adinauer deleted the feat/poc-capture-otel-events branch March 11, 2025 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants