Skip to content

docs: fix :since docs in Finch client #993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
whatyouhide wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −4
Open

docs: fix :since docs in Finch client #993

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/sentry/config.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,9 +430,9 @@ defmodule Sentry.Config do
default: Sentry.FinchClient,
doc: """
A module that implements the `Sentry.HTTPClient`
behaviour. Defaults to `Sentry.FinchClient`, which uses
[Finch](https://github.com/sneako/finch) as the HTTP client.
*The default changed from Hackney to Finch in v10.11.0*.
behaviour. The default client uses
[Finch](https://github.com/sneako/finch) as the HTTP client;
this *changed from Hackney to Finch in v12.0.0*.
"""
],
send_max_attempts: [
Expand Down
2 changes: 1 addition & 1 deletion lib/sentry/finch_client.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ defmodule Sentry.FinchClient do
in the Finch documentation for details on the possible map values.
[finch configuration options](https://hexdocs.pm/finch/Finch.html#start_link/1-pool-configuration-options)
"""
@moduledoc since: "10.11.0"
@moduledoc since: "12.0.0"

@impl true
def child_spec do
Expand Down