fix: Replace deprecated url.parse with parseStringToURLObject #1303
+34
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Bug Fixes 🐛
🤖 This preview updates automatically when you update the PR. |
AbhiPrasad
commented
Jan 27, 2026
| @@ -42,16 +43,19 @@ export interface NetOptions { | |||
| * We want to match the final URL that Electron uses | |||
| */ | |||
| function parseOptions(optionsIn: ClientRequestConstructorOptions | string): { method: string; url: string } { | |||
Member
Author
There was a problem hiding this comment.
Maybe we can evaluate changing this all together?
Node.js 24+ (Electron 40+) emits deprecation warnings for url.parse() which get captured by captureConsoleIntegration and cause test failures. Replace url.parse() calls in net-breadcrumbs.ts with parseStringToURLObject from @sentry/core which uses the WHATWG URL API. Also updates e2e test versions to include Electron 40.0.0. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
AbhiPrasad
force-pushed
the
fix-url-parse-deprecation
branch
from
5de8f1b to
b2ffa30
Compare
Collaborator
|
Could the remaining |
Collaborator
|
It comes internally from Electron: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node.js 24+ (Electron 40+) emits deprecation warnings for url.parse() which get captured by captureConsoleIntegration and cause test failures.
Replace url.parse() calls in net-breadcrumbs.ts with parseStringToURLObject from @sentry/core which uses the WHATWG URL API.
Also updates e2e test versions to include Electron 40.0.0.