-
-
Notifications
You must be signed in to change notification settings - Fork 226
Version 6 release #4803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 6 release #4803
Conversation
|
I believe we need to also update Not sure if we can keep |
Good catch... yeah the prefix will be updated automatically by the Release workflow but definitely need to remove the suffix. ✅ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4803 +/- ##
=======================================
Coverage 73.79% 73.80%
=======================================
Files 483 483
Lines 17547 17547
Branches 3460 3460
=======================================
+ Hits 12949 12950 +1
Misses 3746 3746
+ Partials 852 851 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Flash0ver
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggesting some nit-picky parenthesis fixes.
Co-authored-by: Stefan Pölz <38893694+Flash0ver@users.noreply.github.com>
Co-authored-by: Stefan Pölz <38893694+Flash0ver@users.noreply.github.com>
| @@ -1,59 +1,14 @@ | |||
| # Changelog | |||
|
|
|||
| ## Unreleased | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you released from this branch but the release did not get merged back into here, right? So this should be 6.0.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version 6 release half worked... it published new versions to nuget, so it's available to customers. We were missing the new Extensions.AI package in the release registry though, so the next part of the workflow failed.
We could tweak the version number in this branch and merge it back in to main, but that would leave the craft stuff broken and I think version numbers in the docs wouldn't work.
I opened this PR to address, but it needs review/approval from one of the repo maintainers:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So actually @bitsandfoxes I think we might manually update/merge this in. If you're still working this week, could you review/approve? Stefan No 2 is on holiday this week so you're the best Stefan I've got 😜
We can fix the release registry separately so that we don't have the same problem with future releases.
Tidying up the changelog for the version 6 release (merging all the prerelease change logs and ordering in terms of what customers are most likely to care about).
#skip-changelog