Skip to content

Conversation

@jamescrosswell
Copy link
Collaborator

Tidying up the changelog for the version 6 release (merging all the prerelease change logs and ordering in terms of what customers are most likely to care about).

#skip-changelog

@Flash0ver
Copy link
Member

Flash0ver commented Dec 10, 2025

I believe we need to also update ./Directory.Build.props.

See https://github.com/getsentry/sentry-dotnet/pull/4591/files#diff-9da24614831c308827a1ae533ffea392c97638c261dd42bd0f5226baa136d16e

Not sure if we can keep VersionPrefix as is. But I believe we should remove VersionSuffix again. What do you think?

@jamescrosswell
Copy link
Collaborator Author

I believe we need to also update ./Directory.Build.props.

See https://github.com/getsentry/sentry-dotnet/pull/4591/files#diff-9da24614831c308827a1ae533ffea392c97638c261dd42bd0f5226baa136d16e

Not sure if we can keep VersionPrefix as is. But I believe we should remove VersionSuffix again. What do you think?

Good catch... yeah the prefix will be updated automatically by the Release workflow but definitely need to remove the suffix.

@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.80%. Comparing base (3c5bdb8) to head (67f558e).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4803   +/-   ##
=======================================
  Coverage   73.79%   73.80%           
=======================================
  Files         483      483           
  Lines       17547    17547           
  Branches     3460     3460           
=======================================
+ Hits        12949    12950    +1     
  Misses       3746     3746           
+ Partials      852      851    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@Flash0ver Flash0ver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggesting some nit-picky parenthesis fixes.

jamescrosswell and others added 2 commits December 11, 2025 12:30
Co-authored-by: Stefan Pölz <38893694+Flash0ver@users.noreply.github.com>
Co-authored-by: Stefan Pölz <38893694+Flash0ver@users.noreply.github.com>
@@ -1,59 +1,14 @@
# Changelog

## Unreleased
Copy link
Contributor

@bitsandfoxes bitsandfoxes Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you released from this branch but the release did not get merged back into here, right? So this should be 6.0.0?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version 6 release half worked... it published new versions to nuget, so it's available to customers. We were missing the new Extensions.AI package in the release registry though, so the next part of the workflow failed.

We could tweak the version number in this branch and merge it back in to main, but that would leave the craft stuff broken and I think version numbers in the docs wouldn't work.

I opened this PR to address, but it needs review/approval from one of the repo maintainers:

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So actually @bitsandfoxes I think we might manually update/merge this in. If you're still working this week, could you review/approve? Stefan No 2 is on holiday this week so you're the best Stefan I've got 😜

We can fix the release registry separately so that we don't have the same problem with future releases.

@jamescrosswell jamescrosswell marked this pull request as ready for review December 16, 2025 23:19
@jamescrosswell jamescrosswell merged commit 18bfa9e into main Dec 17, 2025
35 checks passed
@jamescrosswell jamescrosswell deleted the prepare-6.0.0 branch December 17, 2025 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants