Skip to content

chore: InternalVisibleTo Unity SDK tests #4130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bitsandfoxes merged 2 commits into from
Apr 22, 2025
Merged

chore: InternalVisibleTo Unity SDK tests #4130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e309df5
make visible to tests
bitsandfoxes Apr 22, 2025
5ae3d67
removed redundant internal settrace
bitsandfoxes Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Sentry/Sentry.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@

<ItemGroup Condition="'$(SolutionName)' == 'Sentry.Unity'">
<InternalsVisibleTo Include="Sentry.Unity" />
<InternalsVisibleTo Include="Sentry.Unity.Tests" />
</ItemGroup>

<!-- Platform-specific props included here -->
Expand Down
7 changes: 0 additions & 7 deletions src/Sentry/SentrySdk.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,13 +209,6 @@ internal static IDisposable UseHub(IHub hub)
return new DisposeHandle(hub);
}

/// <summary>
/// Allows to set the trace
/// </summary>
internal static void SetTrace(SentryId traceId, SpanId parentSpanId) =>
Copy link
Member

@Flash0ver Flash0ver Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: was added in #4026

CurrentHub.ConfigureScope(scope =>
scope.SetPropagationContext(new SentryPropagationContext(traceId, parentSpanId)));

/// <summary>
/// Flushes the queue of captured events until the timeout set in <see cref="SentryOptions.FlushTimeout"/>
/// is reached.
Expand Down
Loading