fix(a11y): make Ask AI button keyboard-focusable in search bar#17352
Draft
sentry-junior[bot] wants to merge 1 commit intomasterfrom
Draft
fix(a11y): make Ask AI button keyboard-focusable in search bar#17352sentry-junior[bot] wants to merge 1 commit intomasterfrom
sentry-junior[bot] wants to merge 1 commit intomasterfrom
Conversation
The 'Ask AI' control in the search bar was rendered as a styled <div> via Radix's Button pattern, which removes it from the tab order and makes it inaccessible to keyboard and assistive tech users. Remove and the wrapping <div> so Button renders as a native <button> element. Add aria-label="Ask AI" for screen reader clarity. Fixes #17351
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The "Ask AI" control in the search bar was rendered as a styled
<div>via Radix'sButtonasChildpattern. BecauseasChildrenders the child element (the<div>) instead of a native<button>, the control is excluded from the tab order and inaccessible to keyboard and assistive tech users.Changes
In
src/components/search/index.tsx:asChildprop from theButtonwrapping the Ask AI control<div>aria-label="Ask AI"for screen reader clarityThe
Buttonnow renders as a native<button>element, which is keyboard-focusable and tab-navigable by default.Note:
header.tsxalready uses a proper<button>withkapa-ai-classandaria-label—this PR aligns the search bar variant to the same pattern.Closes #17351