Skip to content

docs(javascript): Add list of integrations that use globals #16384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
s1gr1d wants to merge 1 commit into
base: master
Choose a base branch
from
Open

docs(javascript): Add list of integrations that use globals #16384

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/platforms/javascript/common/best-practices/shared-environments.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ When setting up Sentry in a shared environment where multiple Sentry instances m
## Shared Environment Setup

For the use cases listed above, set up a client manually as seen in the example below.
In addition, avoid adding any integrations that use global state, like `Breadcrumbs` or `GlobalHandlers`.
In addition, avoid adding any integrations that use global state, like `Breadcrumbs` or `GlobalHandlers` (see code snippet below).
Furthermore, some default integrations that use the global state have to be filtered as in the example below.
In these scenarios, it's a best practice to avoid using any integrations and to rely on manually capturing errors.

Expand All @@ -64,7 +64,7 @@ import {

// filter integrations that use the global variable
const integrations = getDefaultIntegrations({}).filter((defaultIntegration) => {
return !["BrowserApiErrors", "Breadcrumbs", "GlobalHandlers"].includes(
return !["BrowserApiErrors", "BrowserSession", "Breadcrumbs", "ConversationId", "GlobalHandlers", "FunctionToString"].includes(
Copy link

@sentry sentry bot Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The documentation adds the integration name "ConversationId" to a filter list, but this integration does not exist in the Sentry JavaScript SDK.
Severity: MEDIUM

Suggested Fix

Remove "ConversationId" from the filter list in the documentation file. If it was intended to be a different integration, replace it with the correct, existing integration name.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: docs/platforms/javascript/common/best-practices/shared-environments.mdx#L67

Potential issue: The documentation update adds `"ConversationId"` to a list of
integrations to be filtered out in shared environments. However, `"ConversationId"` is
not a valid integration in the Sentry JavaScript SDK. As a result, when users copy and
use this code, the filter will silently fail to match and remove this non-existent
integration. This misleads developers into believing they have correctly configured
their environment to disable certain global-state-using integrations when they have not.
The other added integrations, `"BrowserSession"` and `"FunctionToString"`, are valid.

Did we get this right? 👍 / 👎 to inform future reviews.

Copy link
Member Author

@s1gr1d s1gr1d Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No this is a correct integration name
https://github.com/getsentry/sentry-javascript/blob/c5e3249496de6cb23c79a1d4a6d1dbf7f00f3f5a/packages/core/src/integrations/conversationId.ts#L8

defaultIntegration.name
);
});
Expand Down