fix(js): Replace hardcoded @sentry/browser imports with ___SDK_PACKAGE___ placeholder#16371
Open
fix(js): Replace hardcoded @sentry/browser imports with ___SDK_PACKAGE___ placeholder#16371
Conversation
…E___ placeholder Code snippets in platform-includes used hardcoded `@sentry/browser` imports, which showed the wrong package name on guide pages (e.g. Next.js guide showed `@sentry/browser` instead of `@sentry/nextjs`). The ___SDK_PACKAGE___ placeholder is already supported by the codeKeywords system and gets replaced at render time with the correct package for each platform/guide. Co-Authored-By: Claude <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
Code snippets across 26
platform-includes/**/javascript.mdxfiles used hardcodedimport * as Sentry from "@sentry/browser"instead of the___SDK_PACKAGE___placeholder. This caused guide pages (e.g./platforms/javascript/guides/nextjs/metrics/) to show@sentry/browserinstead of the correct package (@sentry/nextjs,@sentry/react, etc.).The
___SDK_PACKAGE___placeholder is already supported bycodeKeywords.tsxand gets replaced at render time with the correct package for each platform/guide.@sentry/browserwith___SDK_PACKAGE___in import statements inside code blocks across 26 filessession-replay/setup-canvas/javascript.mdxafter comment removal_defaultfiles, and install command snippetsIS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
🤖 Generated with Claude Code