feat(react-router): Add Instrumentation API guide#16171
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
612602d to
22bf82d
Compare
inventarSarah
left a comment
There was a problem hiding this comment.
Looks good overall! 👍
I added a few suggestions to make the writing more consistent
docs/platforms/javascript/guides/react-router/features/instrumentation-api.mdx
Outdated
Show resolved
Hide resolved
| <SplitSection> | ||
| <SplitSectionText> | ||
|
|
||
| **Before** (manual wrappers): |
There was a problem hiding this comment.
| **Before** (manual wrappers): | |
| **Before migrating** (manual wrappers): |
docs/platforms/javascript/guides/react-router/features/instrumentation-api.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/javascript/guides/react-router/features/instrumentation-api.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/javascript/guides/react-router/features/instrumentation-api.mdx
Show resolved
Hide resolved
docs/platforms/javascript/guides/react-router/features/instrumentation-api.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/javascript/guides/react-router/features/instrumentation-api.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/javascript/guides/react-router/features/instrumentation-api.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/javascript/guides/react-router/features/instrumentation-api.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/javascript/guides/react-router/features/instrumentation-api.mdx
Outdated
Show resolved
Hide resolved
| <Alert level="warning"> | ||
|
|
||
| This SDK is currently in **beta**. Beta features are still in progress and may have bugs. Please reach out on | ||
| [GitHub](https://github.com/getsentry/sentry-javascript/issues/new/choose) if you have any feedback or concerns. |
There was a problem hiding this comment.
Feeling torn about this link. it's not horrible because it works, but it's also really generic. Do we not want an open issue to link to specifically for the beta if we're asking for feedback?
There was a problem hiding this comment.
I'd say that is fair given this will land directly in the SDKs triage queue 👍
| </SplitSection> | ||
| </SplitLayout> | ||
|
|
||
| You can optionally configure error capture behavior: |
There was a problem hiding this comment.
Why is this not split? It looks like a weird formatting break
sfanahata
left a comment
There was a problem hiding this comment.
Content wise, looks fine, though would suggest split format for all of it.
inventarSarah
left a comment
There was a problem hiding this comment.
Looks great! thanks 🎊
<!-- Use this checklist to make sure your PR is ready for merge. You may delete any sections you don't need. --> ## DESCRIBE YOUR PR Documents: getsentry/sentry-javascript#18580 ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE --> - [ ] Other deadline: <!-- ENTER DATE HERE --> - [ ] None: Not urgent, can wait up to 1 week+ ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [x] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) ## EXTRA RESOURCES - [Sentry Docs contributor guide](https://docs.sentry.io/contributing/)
DESCRIBE YOUR PR
Documents: getsentry/sentry-javascript#18580
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
EXTRA RESOURCES