Skip to content

Conversation

@markushi
Copy link
Member

@markushi markushi commented Mar 7, 2025

DESCRIBE YOUR PR

Fixes the docs around in-app-includes and excludes for Android and Java.
Relevant Android PR: getsentry/sentry-java#4240

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

@markushi markushi requested a review from lcian March 7, 2025 10:22
@vercel
Copy link

vercel bot commented Mar 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs 🛑 Canceled (Inspect) Mar 7, 2025 10:49am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Mar 7, 2025 10:49am
develop-docs ⬜️ Ignored (Inspect) Mar 7, 2025 10:49am

@codecov
Copy link

codecov bot commented Mar 7, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.55MB -9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.39MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.57MB -0.0%
../instrumentation.js -3 bytes 904.32kB -0.0%
9523.js -3 bytes 880.37kB -0.0%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.18kB -0.0%
static/chunks/3319-*.js -3 bytes 393.41kB -0.0%
static/bPtvcYO26k44qGkbarD-*.js (New) 578 bytes 578 bytes 100.0% 🚀
static/bPtvcYO26k44qGkbarD-*.js (New) 77 bytes 77 bytes 100.0% 🚀
static/0902a2uXC7_uDmQK9xbUy/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/0902a2uXC7_uDmQK9xbUy/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

@stephanie-anderson stephanie-anderson merged commit 8442e84 into master Mar 7, 2025
11 checks passed
@stephanie-anderson stephanie-anderson deleted the markushi/chore/in-app-includes-excludes branch March 7, 2025 15:09
codyde added a commit that referenced this pull request Mar 13, 2025
…om/getsentry/sentry-docs into codyde/javascript-tracing-refactor

* 'codyde/javascript-tracing-refactor' of https://github.com/getsentry/sentry-docs: (104 commits)
  Update docs/concepts/key-terms/tracing/index.mdx
  Update docs/concepts/key-terms/tracing/index.mdx
  Update docs/concepts/key-terms/tracing/index.mdx
  Update docs/concepts/key-terms/tracing/index.mdx
  Update docs/concepts/key-terms/tracing/index.mdx
  Update docs/concepts/key-terms/tracing/index.mdx
  Update index.mdx (#12928)
  docs(self-hosted): monitor self-hosted instance (#12660)
  fix(feedback): rm per-feedback attach limit (#12968)
  fix(404): php integrations (#12966)
  docs(js): Update stale reference (#12964)
  fix(solidstart): Remove outdated `sentrySolidStartVite` option (#12962)
  chore(sandbox): change sandbox link (#12814)
  feat: Godot debug symbols guide (#12843)
  fix 404s (#12961)
  Fix SDK getting started pages (onboarding options) (#12960)
  fix(platform): Update onboarding options on tab switch (#12913)
  Fix Apollo links (#12952)
  chore(Android): Update docs to match actual SDK behavior (#12954)
  docs(js): Add example docs for non-HTTP protocols (#12933)
  ...
@github-actions github-actions bot locked and limited conversation to collaborators Mar 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants