Skip to content

Conversation

@lcian
Copy link
Member

@lcian lcian commented Feb 14, 2025

DESCRIBE YOUR PR

Adds docs for the (to be released) Apollo 4 integration getsentry/sentry-java#4166
To be merged after release
The content is copied from Apollo 3 docs. I have only changed imports and removed the callout speaking about version 4 being not supported by Sentry.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

@vercel
Copy link

vercel bot commented Feb 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2025 11:44am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Mar 4, 2025 11:44am
develop-docs ⬜️ Ignored (Inspect) Visit Preview Mar 4, 2025 11:44am

@codecov
Copy link

codecov bot commented Feb 14, 2025

Bundle Report

Changes will increase total bundle size by 420 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.93MB 426 bytes (0.0%) ⬆️
sentry-docs-client-array-push 9.39MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 865.35kB -0.0%
static/chunks/1298-*.js -3 bytes 401.61kB -0.0%
static/gMA-*.js (New) 578 bytes 578 bytes 100.0% 🚀
static/gMA-*.js (New) 77 bytes 77 bytes 100.0% 🚀
static/UzfSDbggriopW1jPxIfj-*.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
static/UzfSDbggriopW1jPxIfj-*.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.71MB -0.0%
../instrumentation.js -3 bytes 1.04MB -0.0%
9523.js -3 bytes 1.02MB -0.0%
../app/[[...path]]/page.js.nft.json 145 bytes 376.2kB 0.04%
../app/platform-redirect/page.js.nft.json 145 bytes 376.11kB 0.04%
../app/sitemap.xml/route.js.nft.json 145 bytes 374.08kB 0.04%

Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll let @lbloder do the real review here, just left some comments.

@lcian lcian requested a review from lbloder February 28, 2025 15:40
@lbloder
Copy link
Collaborator

lbloder commented Mar 3, 2025

(h) The Apollo 3 pages have a warning, that the Apollo 3 integration does not support Apollo 4. It would be nice to adapt that warning and link to the new Apollo 4 pages.

@lcian
Copy link
Member Author

lcian commented Mar 3, 2025

(h) The Apollo 3 pages have a warning, that the Apollo 3 integration does not support Apollo 4. It would be nice to adapt that warning and link to the new Apollo 4 pages.

Yep, we're doing it here #12731 and here #12730
Those need to be merged after this one though otherwise we will link to a nonexistent page

Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcian lcian merged commit 97cfbe7 into master Mar 6, 2025
11 checks passed
@lcian lcian deleted the lcian/feat/apollo-4-init branch March 6, 2025 12:29
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants