chore(deps): update CLI to v3.4.3#354
Conversation
aaa311f to
7b3e8c5
Compare
7b3e8c5 to
171924a
Compare
171924a to
3affc16
Compare
3affc16 to
423ccc9
Compare
e25a66e to
0e45c70
Compare
0e45c70 to
dbfed39
Compare
acdc8dc to
2d72f91
Compare
2d72f91 to
f3d8d51
Compare
f3d8d51 to
da795e7
Compare
da795e7 to
13fb3a3
Compare
13fb3a3 to
a3a278e
Compare
a3a278e to
95a0799
Compare
95a0799 to
461c338
Compare
461c338 to
1bfa61b
Compare
89dbf38 to
ae19cda
Compare
117ca83 to
0fddbce
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| import 'host_platform.dart'; | ||
|
|
||
| const _version = '2.52.0'; | ||
| const _version = '3.2.2'; |
There was a problem hiding this comment.
Legacy source map upload uses removed CLI command
High Severity
Bumping sentry-cli from 2.x to 3.x breaks the legacyWebSymbolication code path. The _executeCliForLegacySourceMaps method constructs commands using releases files <release> upload-sourcemaps, but sentry-cli 3.0.0 explicitly removed all releases files subcommands. Users with legacy_web_symbolication: true in their config will experience runtime failures when uploading source maps. The option is still exposed and configurable with no deprecation warning or guard.
0fddbce to
04af768
Compare
04af768 to
505560e
Compare
ab08589 to
3f1cc67
Compare
3f1cc67 to
c3ab30f
Compare
814af63 to
99a4a2d
Compare
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Internal Changes 🔧Deps
Release
Other
Other
🤖 This preview updates automatically when you update the PR. |
99a4a2d to
6be08eb
Compare
6be08eb to
3993517
Compare
3993517 to
0f87e2c
Compare
| @@ -4,37 +4,37 @@ import 'package:sentry_dart_plugin/src/cli/sources.dart'; | |||
|
|
|||
There was a problem hiding this comment.
Bug: The legacyWebSymbolication option uses a sentry-cli command that was removed in the updated version, causing source map uploads to fail.
Severity: HIGH
Suggested Fix
Update the _executeCliForLegacySourceMaps method to use the modern sentry-cli sourcemaps upload command instead of the removed sentry-cli releases files ... upload-sourcemaps command. This will restore compatibility for the legacy web symbolication feature with the new CLI version.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: lib/src/cli/_sources.dart#L4
Potential issue: The plugin's `legacyWebSymbolication` feature invokes the `sentry-cli
releases files <release> upload-sourcemaps <folder>` command. This pull request updates
the bundled `sentry-cli` to a version where `sentry-cli releases files ...` subcommands
have been removed. Consequently, users who have `legacyWebSymbolication: true` in their
configuration will experience command-line failures when the
`_executeCliForLegacySourceMaps` method attempts to upload source maps using the
now-nonexistent command.
Did we get this right? 👍 / 👎 to inform future reviews.
| @@ -4,37 +4,37 @@ import 'package:sentry_dart_plugin/src/cli/sources.dart'; | |||
|
|
|||
There was a problem hiding this comment.
Bug: The _executeCliForLegacySourceMaps function uses the releases files upload-sourcemaps command, which was removed in sentry-cli v3.0.0, breaking legacy web symbolication.
Severity: HIGH
Suggested Fix
Update the _executeCliForLegacySourceMaps function to use the new sentry-cli sourcemaps upload command, which is the recommended replacement. Alternatively, implement a version check for sentry-cli and either use the correct command based on the version or show an error if a user attempts to use legacy symbolication with an incompatible CLI version.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: lib/src/cli/_sources.dart#L4
Potential issue: The PR updates `sentry-cli` to v3.4.3, which removes the `releases
files upload-sourcemaps` command. The `_executeCliForLegacySourceMaps` function,
triggered when `legacy_web_symbolication` is set to `true`, still uses this removed
command. This will cause a runtime error when the CLI is executed, preventing source map
uploads for users who have opted into this legacy mode. The failure will break
symbolication for their web builds. The code does not contain any version checking or
fallback logic to handle this breaking change introduced by the `sentry-cli` update.


Bumps scripts/update-cli.sh from 2.58.6 to 3.4.3.
Auto-generated by a dependency updater.
Changelog
3.4.3
Security Fixes
Info.plistpreprocessing by default to avoid passing project-controlled compiler settings toccduring release auto-discovery. This affectssentry-cli releases propose-version,sentry-cli send-eventandsentry-cli bash-hook --send-eventrelease inference, andsentry-cli react-native xcodeauto-release detection. Use--allow-xcode-infoplist-preprocessingonly for trusted projects that require preprocessing.sentry-cli loginupdates existing config files.http.verify_sslis set tofalse, case-insensitively.bash-hookarguments, including paths, tags, release names, and the CLI path.sentry-cli bash-hookevents.sentry-cli update.Performance
Fixes
3.4.2
Fixes
serializeOptions. String/number options now validate input types and preventArray.prototype.concat()from flattening array values into separate CLI arguments. (#3287)3.4.1
Improvements
--excludeto scope the bundle to a single variant (#3275).Fixes
[<module>/]src/<sourceset>/<lang>/prefix from bundle URLs so Symbolicator can resolve them from package-based stack traces (e.g.sentry-android-core/src/main/java/io/sentry/android/core/ANRWatchDog.java→~/io/sentry/android/core/ANRWatchDog.jvm) (#3275).3.4.0
Features
--selectiveflag tobuild snapshotsto indicate the upload contains only a subset of images (#3268).java,.kt,.scala,.groovy), respecting.gitignore, and excluding common build output directories (#3260)--excludeoption for custom glob patterns to exclude files/directories from source collection (#3260)Performance
Fixes
eprintln!withlog::info!for progress bar completion messages when the progress bar is disabled (e.g. in CI). This avoids spurious stderr output that some CI systems treat as errors (#3223).3.3.5
Performance
Fixes
3.3.4
New Features ✨
--diff-thresholdoption tobuild snapshotsto set a minimum pixel difference percentage for reporting image changes (#3259)sentry-cli build downloadcommand to download installable builds (IPA/APK) by build ID (#3221).sentry-cli code-mappings uploadcommand to bulk upload code mappings from a JSON file (#3207, #3208, #3209, #3210).com/example/module) to source paths in your repository (e.g.src/main/java/com/example/module), enabling Sentry to display source context and link directly to your code from error stack traces.--repoand--default-branch.3.3.3
Internal Changes 🔧
3.3.2
New Features ✨
Internal Changes 🔧
3.3.1
Fixes
.xcarchiveor.ipafiles on non-Apple Silicon Macs (#3211).Experimental Feature 🧑🔬 (internal-only)
sentry-cli build snapshotscommand (#3163).3.3.0
New Features
sentry-cli proguard uuid <PATH>to compute and print the UUID for a ProGuard mapping file (#3176).Improvements
sentry-cli upload-proguardtosentry-cli proguard upload, aligning the API with similar upload commands likedebug-files uploadandsourcemaps upload(#3174).sentry-cli upload-proguardremains supported as an alias, so no migration is required.Experimental Feature 🧑🔬 (internal-only)
3.2.3
Experimental Feature 🧑🔬 (internal-only)
sentry-cli build snapshotscommand to upload build snapshots to a project (#3110).3.2.2
Fixes
minimatchdependency to fix a vulnerability (#3153)3.2.1
Fixes
dart-symbol-map uploadcommand now correctly resolves the organization from the auth token payload (#3065).sentry.iorequests to reduce intermittent failures for some users (#3085)3.2.0
Features
sourceMaps.inject()for injecting debug IDs (#3088)--install-groupparameter tosentry-cli build uploadfor controlling update visibility between builds (#3094)Fixes
*.ghe.comURLs asgithub_enterpriseVCS provider (#3127).dart-symbol-mapcommand did not accept the--urlargument (#3108).build uploadpolling loop to prevent infinite loop when server returns unexpected state (#3118).3.1.0
New Features
releases.newDeploy()method. This method now accept aprojectsoption (array of project slugs), aligning them with the Rust CLI's multi-project capabilities and matching the existing behavior ofreleases.new()andreleases.uploadSourceMaps()(#3001).Improvements
Fixes
sentry-cli releases newcommand for users with self-hosted Sentry instances on versions older than 25.12.1 (#3068).sentry-cli releases listcommand ignored the--projectoption (#3048). The command now correctly can filter releases by a single project when supplied via--project. This change does not enable filtering by multiple projects, which has never been supported.3.0.3
Fixes
3.0.2
Fixes
Versioning Policy Update
Our versioning policy has reclassified the minimum supported self-hosted Sentry version as being part of the public API. Therefore, we will only increase this minimum supported self-hosted Sentry version in a major release of Sentry CLI.
3.0.1
Performance Improvements
sentry build upload) in preparation for this week's beta release! (#3038)3.0.0
New Sentry Support Policy
sentry-cli3.0.0 and above only officially supports Sentry SaaS and Sentry self-hosted versions 25.11.1 and higher. While many Sentry CLI features may, in practice, continue working with some older Sentry versions, continued support for Sentry versions older than 25.11.1 is not guaranteed. Changes which break support for Sentry versions below 25.11.1 may occur in minor or patch releases.New Versioning Policy
Sentry CLI now defines a semantic versioning policy. We did not explicitly define a versioning policy previously, and this new policy should give more clarity about what can change in minor or patch releases versus what requires a major version bump.
Breaking Changes
sentry-cli files ...andsentry-cli releases files ...subcommands (#2956). These commands provided functionality for managing release files, a feature that has been deprecated in Sentry. Users still usingsentry-cli files uploadto upload source maps should migrate tosentry-cli sourcemaps upload.sentry-cli sourcemaps explaincommand (#2947). The command had been deprecated for some time, since Sentry now has a better in-product debugging flow for source map problems via the "Unminify Code" button, which is displayed on any JavaScript issues which could not be unminified.sentry-cli send-metric ...subcommands (#3006). These commands have been deprecated, and the data they send is no longer accepted by Sentry.--api-keyCLI flagSENTRY_API_KEYenvironment variableapi_keyconfiguration file fieldapiKeyoption in the JavaScript APIupload-proguardsubcommand's--app-id,--version,--version-code,--android-manifest, and--platformarguments (#2876, #2940, #2948). Users using these arguments should stop using them, as they are unnecessary. The information passed to these arguments is no longer visible in Sentry.--startedargument from thesentry-cli releases finalizecommand (#2972). This argument is a no-op, so any users using it should simply stop using it.--use-artifact-bundleflag fromsentry-cli sourcemaps upload(#3002). The flag was a no-op that only emitted a deprecation warning.Node.js Wrapper Breakages
The following changes only apply when using
sentry-clivia the npm packagesentry/cli:The
SentryCli.executemethod'sliveparameter now only takes boolean values (#2971). Settinglivetotruenow behaves like'rejectOnError'did previously, with a zero exit status resolving the returned promise with"success (live mode)"and a non-zero status rejecting the promise with an error message.The
optionparameter toReleases.uploadSourceMapsno longer takes aliveproperty (#2971). We now always execute the command withliveset totrue.Removed the
apiKeyoption fromSentryCliOptions(#2935). If you are usingapiKey, you need to generate and use an Auth Token via theauthTokenoption, instead.Removed the
useArtifactBundleoption fromSentryCliUploadSourceMapsOptions(#3002). This deprecated option was a no-op that users should simply stop passing.Drop support for Node.js <18. The minimum required Node.js version is now 18.0.0 (#2985).
The type export
SentryCliReleaseshas been removed.The JavaScript wrapper now uses named exports instead of default exports (#2989). You need to update your imports:
For ESM imports:
Improvements
sentry-cli upload-proguardcommand now uses chunked uploading by default (#2918). Users who previously set theSENTRY_EXPERIMENTAL_PROGUARD_CHUNK_UPLOADenvironment variable to opt into this behavior no longer need to set the variable.debugIdfield, per the TC39 Debug ID proposal (#3005). This change affects thesentry-cli sourcemaps injectcommand and, unless--no-rewriteis passed, thesentry-cli sourcemaps uploadcommand. Sentry CLI can still read thedebug_idfield, but whenever the CLI writes or rewrites a source map, we always usedebugId.sentry-cli build uploadcommand now automatically tracks Sentry plugin versions from theSENTRY_PIPELINEenvironment variable (#2994). WhenSENTRY_PIPELINEcontains a recognized Sentry plugin (e.g.,sentry-gradle-plugin/4.12.0orsentry-fastlane-plugin/1.2.3), the plugin version is written to the.sentry-cli-metadata.txtfile in uploaded build archives, enabling the backend to store metadata for size analysis and build distribution tracking.Fixes