Store SourceView linecache as offsets rather than pointers#133
Merged
loewenheim merged 2 commits intogetsentry:masterfrom Dec 4, 2025
Merged
Store SourceView linecache as offsets rather than pointers#133loewenheim merged 2 commits intogetsentry:masterfrom
loewenheim merged 2 commits intogetsentry:masterfrom
Conversation
coolreader18
force-pushed
the
improve-sourceview
branch
from
81583f7 to
17d47a2
Compare
coolreader18
force-pushed
the
improve-sourceview
branch
from
17d47a2 to
f8b461a
Compare
loewenheim
approved these changes
Dec 2, 2025
Contributor
loewenheim
left a comment
loewenheim
left a comment
There was a problem hiding this comment.
Hi, thank you for the nice contribution! I just have one stylistic nit.
loewenheim
reviewed
Dec 2, 2025
loewenheim
reviewed
Dec 2, 2025
loewenheim
approved these changes
Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This eliminates the unsafe code in this module, and also uses less memory (1 machine word per line rather than 2).
I originally thought I could just store the offsets pointing to the end of the line, but then realized that the string returned by
get_line()doesn't include the line terminator, so I bitpacked the type of line terminator into the index. If that's too overengineered, I could change it to just trim a trailing cr/lf/crlf off the string, but that might entail extra branching in the happy path.