feat: Implement MultipartUploadBackend on TieredStorage#458
Merged
Conversation
lcian
changed the title
lcian
changed the base branch from
main
to
lcian/feat/multipart-upload-other-backends
This comment has been minimized.
This comment has been minimized.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
lcian
commented
May 7, 2026
lcian
commented
May 7, 2026
This comment was marked as off-topic.
This comment was marked as off-topic.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
lcian
commented
May 8, 2026
matt-codecov
approved these changes
May 11, 2026
lcian
force-pushed
the
lcian/feat/multipart-upload-other-backends
branch
from
e8a193d to
803c658
Compare
Base automatically changed from
lcian/feat/multipart-upload-other-backends
to
main
May 12, 2026 11:22
Move ChangeGuard creation before get_metadata so that if the metadata read fails after complete_multipart succeeds, the guard cleans up the assembled blob. Previously, Manual-expiration objects could be orphaned permanently. Also fix redundant rustdoc link.
lcian
force-pushed
the
lcian/feat/multipart-upload-tiered
branch
from
409be20 to
d6eb979
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d6eb979. Configure here.
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Turning this into a draft to avoid getting confused until #480 has been reviewed. |
…480)⚠️ Stacked on #458 This addresses the issue being discussed in #458 (comment) by introducing a new `ChangePhase::Assembling` variant. The corresponding `Change` carries a `cleanup_after` timestamp, allowing the caller to defer cleanup. In practice, we use this in `TieredStorage::complete_multipart` with an arbitrary 24 hours deadline (should we change this?), during which the user can freely retry completing the upload. Note that this `ChangePhase` is special, as it behaves like `ChangePhase::complete` in-process: - It does nothing on `Drop`, as we assume that the deadline hasn't passed yet. - The corresponding `ChangeGuard` for it also doesn't spawn any task on `Drop`, due to the same assumption. As a consequence, this depends on a persistent implementation of the `ChangeLog` to actually clean anything up, or at least on a task that periodically scans the in-memory `ChangeLog` for `Change`s to clean up, both of which we don't have yet. In production, we will eventually always use a persistent `ChangeLog`, and other code paths exist that similarly require a persistent `ChangeLog` to actually ensure that no LT orphans are created, so I think it's fine for this change to also make that assumption. Part of FS-339. Will be squash-merged into #458 once approved.
lcian
added a commit
that referenced
this pull request
May 29, 2026
⚠️ Stacked on #458 Final part of the Multipart uploads implementation server-side, this implements the endpoints on top of the Service. Close FS-341 Close FS-359
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last implementation of
MultipartUploadBackendinobjectstore-service.Now
TieredStoragerequires aMultipartUploadBackendin itslong_termslot.All methods just pretty much forward to
long_term, with the exception ofcomplete_multipartwhich needs to use theChangelogfor consistency and deal with the tombstones, with logic very similar toput_objectexcept that we need an additional metadata read call.Close FS-339