test: Add tests for GCS multipart uploads#454
Merged
Conversation
lcian
changed the title
matt-codecov
approved these changes
May 5, 2026
Contributor
matt-codecov
left a comment
matt-codecov
left a comment
There was a problem hiding this comment.
are you planning to try to upstream your multipart upload support?
gave the tests a quick scan
Member
Author
Not for now, as it would probably require some effort to get the PR into proper shape for it to be accepted, and I'd rather focus on our projects instead. |
lcian
force-pushed
the
lcian/test/gcs-multipart
branch
from
36f1380 to
0e21505
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
lcian
added a commit
that referenced
this pull request
May 12, 2026
…Fs (#456)⚠️ Stacked on #454 Implements `MultipartUploadBackend` on `InMemoryBackend` and `LocalFsBackend`, used for tests. `TieredStorage` will come in the next PR. `InMemoryBackend` now stores some auxiliary data structures dedicated to multipart uploads, while `LocalFs` uses a `__multipart__/` directory where to store metadata and parts for each ongoing upload. Close FS-349
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds e2e tests against our fork of https://github.com/googleapis/storage-testbench, which contains an XML API multipart upload implementation https://github.com/getsentry/google-cloud-storage-testbench
Also switches devservices to use that fork.
The implementation present in this fork has been completely written by LLMs, so it should not be trusted for anything but catching obvious regressions if we ever make changes to the GCS backend.
Any non-trivial change to the GCS backend that touches the multipart upload implementation should be tested in sandbox against real GCS before merging.
I've added a code comment about this too.
Part of #450, will be merged into it.
Part of FS-338