Draft
Conversation
Read the auth token from the `X-Os-Auth` query parameter as a fallback between the `X-Os-Auth` header and the `Authorization` header. The query parameter value is the raw JWT without a `Bearer` prefix, useful for contexts where headers cannot be set (e.g. browser-initiated requests). Precedence: X-Os-Auth header > X-Os-Auth query param > Authorization header.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is needed for getsentry/sentry#113030.
It allows frontend pages that use standard image components to slap
?X-Os-Auth=<token>to the URLs they retrieve images from, as opposed to needing custom logic to add it as a header whenever the image is known to be stored in Objectstore.This is the final piece of the puzzle that will allow us to enable auth enforcement and unblock Emerge for EA of Snapshots.
The proper solution would be pre-signed URLs, but that needs design and is significantly more complex. We don't want that to be a blocker for Snapshots.
Moreover, we're already passing JWTs around anyways (see
symbolicatorfor attachments andsentry-clifor snapshot uploads).