feat(gcs): Introduce retries #279
Open
+159
−81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces retries for the GCS backend.
The whole retry behavior is very similar to the one we use for GCS: maximum 2 retries and we retry immediately.
The only difference is that we don't retry PUTs, as we would have to buffer possibly huge payloads to do so.
This is still not perfect, as GCP recommends using exponential backoff for retries.
While I agree that would be a better strategy, users are likely to set timeouts on their end, and waiting too much is likely to have them run into timeouts and therefore see the request as failed from their point of view.
I still see this as an improvement to handle transient network failures that could very well disappear by simply retrying immediately.
Close FS-188