feat(bigtable): Retry selectively #278
Open
+64
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcian
commented
Jan 28, 2026
| } | ||
| retry_count += 1; | ||
| merni::counter!("bigtable.read_retry": 1); | ||
| tracing::debug!(retry_count = retry_count, "Retrying read"); |
Member
Author
There was a problem hiding this comment.
This was supposed to be a tracing::debug I think so I changed it.
tracing::warn was ending up in Sentry, even though we already capture this as a metric in DD.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the Bigtable backend so that we only retry when it makes sense to do so.
I've determined which errors can be retried by checking the code of bigtable_rs (turns out some of the errors can literally never happen, but for some reason
thiserrorenums don't emit dead code warnings for unused enum variants) and the official Bigtable docs.I've also added a widget displaying this metric in Datadog as we weren't using it, it might be useful to easily detect if there's any issues with BigTable on the GCP side.
Part of FS-188