-
-
Notifications
You must be signed in to change notification settings - Fork 4
feat(rust-client): Implement many API using batch endpoint #277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
lcian
wants to merge
21
commits into
lcian/feat/batch-impl
Choose a base branch
from
lcian/feat/rust-batch-client
base: lcian/feat/batch-impl
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@sentry review |
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog. No changelog entries will be generated from this PR. 🤖 This preview updates automatically when you update the PR. |
Member
Author
|
@sentry review |
3f49d54 to
d6dbeee
Compare
4fbfd7f to
7f060c7
Compare
7f060c7 to
bf71d9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
manyAPI that submits batch requests to the server.The API is called
manyto indicate the fact that this can be interpreted as just a "hint" to use batching, but amanyrequest from the user's pov doesn't necessarily map to a single batch request to the server.This is a nice API when creating the requests but not so nice when retrieving the results, as the user will need to deal with wrapper types and different error types as well.
It should be kept in mind that most of the usage we expect here is from
sentry-cliuploading multiple files. It's therefore quite unlikely that the user wants to inspect the result wrappers or anyways match on the errors, they most likely just care to know if all operations succeeded or not.Motivated by the above reasons:
error_for_failuresfunction that's useful if you just want to know if all ops succeeded or not