feat: Automatic version bumping from configured targets #707
+1,363
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When minVersion >= 2.19.0 and no preReleaseCommand is defined, Craft automatically bumps version numbers based on configured publish targets. Supported targets: - npm: npm version --no-git-tag-version - pypi: hatch, poetry, setuptools-scm, or direct pyproject.toml edit - crates: cargo set-version (cargo-edit) - gem: Direct edit of gemspec and lib/**/version.rb - pub-dev: Direct edit of pubspec.yaml - hex: Direct edit of mix.exs - nuget: dotnet-setversion or direct XML edit Fixes #76
Contributor
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
🤖 This preview updates automatically when you update the PR. |
For npm/yarn/pnpm monorepos, automatically detect and bump versions in all workspace packages: - npm 7+: Uses npm version --workspaces - yarn/pnpm or npm < 7: Falls back to individual package bumping Private packages are skipped during workspace version bumping.
Tests cover: - runAutomaticVersionBumps utility function - NpmTarget.bumpVersion (including workspace detection) - PypiTarget.bumpVersion (hatch, poetry, setuptools-scm, direct edit) - CratesTarget.bumpVersion - GemTarget.bumpVersion - PubDevTarget.bumpVersion - HexTarget.bumpVersion - NugetTarget.bumpVersion
- Remove obvious comments (// Check if X exists) - Simplify verbose multi-line comments to single lines - Remove redundant JSDoc field descriptions - Clean up try/catch blocks with explicit early returns - Shorten verbose error messages
| rootDir: string, | ||
| newVersion: string | ||
| ): Promise<boolean> { | ||
| const gemspecFiles = readdirSync(rootDir).filter(f => f.endsWith('.gemspec')); |
Member
There was a problem hiding this comment.
sentry-ruby is a monorepo of several gems where each gemspec is not in the root dir but a subdir, example: https://github.com/getsentry/sentry-ruby/blob/master/sentry-ruby/sentry-ruby.gemspec
betegon
reviewed
Jan 13, 2026
| For npm/yarn/pnpm monorepos, Craft automatically detects and bumps versions in all workspace packages: | ||
|
|
||
| - **npm 7+**: Uses `npm version --workspaces` to bump all packages at once | ||
| - **yarn/pnpm or npm < 7**: Falls back to bumping each non-private package individually |
Member
There was a problem hiding this comment.
where's my dear Bun? we can add it later, i think we could just look for Bun lockfiles bun.lockb / bun.lock, add BUN_BIN, USE_BUN env vars, and bun publishsupport.
Member
There was a problem hiding this comment.
it supports workspaces too https://bun.com/docs/pm/workspaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When
minVersion >= 2.19.0and no custompreReleaseCommandis defined, Craft automatically bumps version numbers based on configured publish targets. This eliminates the need for ascripts/bump-version.shscript in most cases.How It Works
targetsin.craft.ymlSupported Targets
npmpackage.jsonnpm version --no-git-tag-versionpypipyproject.tomlcratesCargo.tomlcargo set-version(cargo-edit)gem*.gemspeclib/**/version.rbpub-devpubspec.yamlhexmix.exsnuget*.csprojPython (pypi) Detection Priority
[tool.hatch]→hatch version <version>[tool.poetry]→poetry version <version>[tool.setuptools_scm]→ No-op (version from git tags)[project]with version → Direct TOML editBreaking Changes
None. Existing projects continue to work unchanged. The feature is gated behind
minVersion: "2.19.0".Fixes #76