fix(mac): use arm64 thread state accessors on new Apple SDKs#45
Open
zhaowq32 wants to merge 1 commit into
Open
fix(mac): use arm64 thread state accessors on new Apple SDKs#45zhaowq32 wants to merge 1 commit into
zhaowq32 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Newer Apple SDKs expose
__darwin_arm_thread_state64through accessor macros instead of allowing direct access to fields such as__fp,__lr,__sp, and__pc.This change updates Breakpad's macOS arm64 context population code to prefer the official SDK accessors when available, while preserving the existing field-based code path for older SDKs.
Problem
With newer Xcode / macOS SDKs, Breakpad fails to compile in
src/client/mac/handler/minidump_generator.ccwith errors like:This breaks downstream consumers that vendor Breakpad, including macOS arm64/arm64e builds.
Fix
Use feature-based compatibility logic instead of SDK version checks:
If the SDK provides:
then use those official accessors.
Otherwise, fall back to the existing direct field assignments for older SDKs.