Add invalid polygon changes #334
Conversation
| | <a id="data-type:geopoint" href="#data-type:geopoint">`geopoint`</a> | Space-separated list of valid latitude (decimal degrees), longitude (decimal degrees), altitude (decimal meters) and accuracy (decimal meters) | ||
| | <a id="data-type:geotrace" href="#data-type:geotrace">`geotrace`</a> | Semi-colon-separated list of at least 2 geopoints, where the last geopoint's latitude and longitude is not equal to the first | ||
| | <a id="data-type:geoshape" href="#data-type:geoshape">`geoshape`</a> | Semi-colon-separated list of at least 3 geopoints, where the last geopoint's latitude and longitude is equal to the first | ||
| | <a id="data-type:geotrace" href="#data-type:geotrace">`geotrace`</a> | Semi-colon-separated list of at least 2 geopoints, where the last geopoint's latitude and longitude is not equal to the first.<br><br>If an `input` with this type has the `incremental` attribute with the value `true`, any change to the value such as moving a vertex, adding a vertex, removing a vertex results in validating the new value and showing a constraint message if the constraint is violated. Clients may additionally choose to block the addition of new points when a constraint is violated to draw user attention to the problem. Clients may choose to recalculate and revalidate the whole form or not depending on performance considerations and how they display geo questions. |
There was a problem hiding this comment.
Apparently <br> is the only way to get a paragraph break in tables in Markdown!
There was a problem hiding this comment.
Looks good! I suggest also considering the following diff which says only the minimum required behaviour
If an
inputwith this type has theincrementalattribute with the valuetrue, any interactive change to the form control input value must trigger validation of the new value.
There was a problem hiding this comment.
I know it's pretty verbose, but I prefer the more specific text for now unless you're very against it?
| | control | description | ||
| |---------------|------------ | ||
| |`<input>` | This element is used to obtain user input for data types: string, integer, decimal, and date. As in [XForms 1.0](https://www.w3.org/TR/2003/REC-xforms-20031014/slice8.html#ui-input) without Special Attributes support. | ||
| |`<input>` | This element is used to obtain user input for data types: string, integer, decimal, and date. As in [XForms 1.0](https://www.w3.org/TR/2003/REC-xforms-20031014/slice8.html#ui-input) without Special Attributes support. This is with the exception of when the `geotrace` or `geoshape` types are used - in that case, `incremental` is supported. |
There was a problem hiding this comment.
Wonder why ODK went with appearance instead of inputmode URIs
There was a problem hiding this comment.
I think that is lost to history! I would say in general JavaRosa was originally inspired by W3C XForms but did not aspire to follow it strictly. Over time we've tried to align them where possible but ODK XForms is still very much a separate spec.
3 participants
Closes #333
Closes #332
This adds the changes we've made to support the invalid polygon feature set. Definitely open to discussing where each detail should live!