-
Notifications
You must be signed in to change notification settings - Fork 21
feat(#662): replace tooltips in maps with dialog #737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
4b6e05a
adds spacing variables and add info dialog
latin-panda e708f74
adjust buttons display
latin-panda 7809aa0
adjust buttons display
latin-panda 5ba9483
Merge branch 'main' of https://github.com/getodk/web-forms into info-…
latin-panda 96b9120
add changeset
latin-panda 5dea0d5
Removes toolip in edit coordinates dialog
latin-panda 7a88062
displays advanced panel on top of controls
latin-panda 4d96418
properties panel adjusted height
latin-panda c50e966
Adds variable to odk styles
latin-panda 9279ba4
updates e2e tests
latin-panda f6955d9
updates e2e tests
latin-panda ce34c3c
feedback: accessibility and list styles
latin-panda 221ac20
feedback: media query
latin-panda 92ed5a4
adds placeholder
latin-panda 15a895d
Feedback - removed button
latin-panda 7b9be23
fixes lint
latin-panda File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@getodk/web-forms': patch | ||
| --- | ||
|
|
||
| Changed the map tooltips to a dialog that explains the actions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+4.13 KB
(110%)
...ll-question-types.test.ts-snapshots/geopoint-maps-current-location-chromium.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+907 Bytes
(100%)
...all-question-types.test.ts-snapshots/geopoint-maps-current-location-firefox.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.15 KB
(100%)
.../all-question-types.test.ts-snapshots/geopoint-maps-current-location-webkit.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-32.1 KB
(42%)
...l/all-question-types.test.ts-snapshots/geopoint-maps-initial-state-chromium.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-33.4 KB
(51%)
...al/all-question-types.test.ts-snapshots/geopoint-maps-initial-state-firefox.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-46.5 KB
(45%)
...ual/all-question-types.test.ts-snapshots/geopoint-maps-initial-state-webkit.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-13.6 KB
(87%)
...al/all-question-types.test.ts-snapshots/geoshape-autoclose-polygon-chromium.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-2.73 KB
(97%)
...ual/all-question-types.test.ts-snapshots/geoshape-autoclose-polygon-firefox.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-2.53 KB
(98%)
...sual/all-question-types.test.ts-snapshots/geoshape-autoclose-polygon-webkit.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-11.5 KB
(88%)
...visual/all-question-types.test.ts-snapshots/geoshape-initial-state-chromium.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+618 Bytes
(100%)
.../visual/all-question-types.test.ts-snapshots/geoshape-initial-state-firefox.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+838 Bytes
(100%)
...s/visual/all-question-types.test.ts-snapshots/geoshape-initial-state-webkit.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-2.09 KB
(98%)
.../visual/all-question-types.test.ts-snapshots/geoshape-three-points-chromium.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-3.02 KB
(97%)
...s/visual/all-question-types.test.ts-snapshots/geoshape-three-points-firefox.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-2.54 KB
(98%)
...es/visual/all-question-types.test.ts-snapshots/geoshape-three-points-webkit.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-11.7 KB
(88%)
.../all-question-types.test.ts-snapshots/geoshape-uncompleted-polygon-chromium.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+665 Bytes
(100%)
...l/all-question-types.test.ts-snapshots/geoshape-uncompleted-polygon-firefox.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+859 Bytes
(100%)
...al/all-question-types.test.ts-snapshots/geoshape-uncompleted-polygon-webkit.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+548 Bytes
(100%)
...visual/all-question-types.test.ts-snapshots/geotrace-initial-state-chromium.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+609 Bytes
(100%)
.../visual/all-question-types.test.ts-snapshots/geotrace-initial-state-firefox.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+872 Bytes
(100%)
...s/visual/all-question-types.test.ts-snapshots/geotrace-initial-state-webkit.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-2.88 KB
(97%)
...es/visual/all-question-types.test.ts-snapshots/geotrace-two-points-chromium.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-2.47 KB
(98%)
...ses/visual/all-question-types.test.ts-snapshots/geotrace-two-points-firefox.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-2.45 KB
(98%)
...ases/visual/all-question-types.test.ts-snapshots/geotrace-two-points-webkit.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+498 Bytes
(100%)
...ll-question-types.test.ts-snapshots/placement-map-current-location-chromium.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.39 KB
(100%)
...all-question-types.test.ts-snapshots/placement-map-current-location-firefox.png
Oops, something went wrong.
Binary file modified
BIN
+1.11 KB
(100%)
.../all-question-types.test.ts-snapshots/placement-map-current-location-webkit.png
Oops, something went wrong.
Binary file modified
BIN
-259 Bytes
(100%)
...l/all-question-types.test.ts-snapshots/placement-map-initial-state-chromium.png
Oops, something went wrong.
Binary file modified
BIN
+785 Bytes
(100%)
...al/all-question-types.test.ts-snapshots/placement-map-initial-state-firefox.png
Oops, something went wrong.
Binary file modified
BIN
+906 Bytes
(100%)
...ual/all-question-types.test.ts-snapshots/placement-map-initial-state-webkit.png
Oops, something went wrong.
Binary file modified
BIN
+518 Bytes
(100%)
...all-question-types.test.ts-snapshots/placement-map-new-point-saved-chromium.png
Oops, something went wrong.
Binary file modified
BIN
+1.23 KB
(100%)
.../all-question-types.test.ts-snapshots/placement-map-new-point-saved-firefox.png
Oops, something went wrong.
Binary file modified
BIN
+1.02 KB
(100%)
...l/all-question-types.test.ts-snapshots/placement-map-new-point-saved-webkit.png
Oops, something went wrong.
Binary file modified
BIN
+555 Bytes
(100%)
...l/all-question-types.test.ts-snapshots/placement-map-point-removed-chromium.png
Oops, something went wrong.
Binary file modified
BIN
+1.39 KB
(100%)
...al/all-question-types.test.ts-snapshots/placement-map-point-removed-firefox.png
Oops, something went wrong.
Binary file modified
BIN
+1.08 KB
(100%)
...ual/all-question-types.test.ts-snapshots/placement-map-point-removed-webkit.png
Oops, something went wrong.
Binary file modified
BIN
+739 Bytes
(100%)
...visual/all-question-types.test.ts-snapshots/select-map-full-screen-chromium.png
Oops, something went wrong.
Binary file modified
BIN
+1.64 KB
(100%)
.../visual/all-question-types.test.ts-snapshots/select-map-full-screen-firefox.png
Oops, something went wrong.
Binary file modified
BIN
+1.09 KB
(100%)
...s/visual/all-question-types.test.ts-snapshots/select-map-full-screen-webkit.png
Oops, something went wrong.
Binary file modified
BIN
+15.1 KB
(130%)
...sual/all-question-types.test.ts-snapshots/select-map-initial-state-chromium.png
Oops, something went wrong.
Binary file modified
BIN
+470 Bytes
(100%)
...isual/all-question-types.test.ts-snapshots/select-map-initial-state-firefox.png
Oops, something went wrong.
Binary file modified
BIN
+19.2 KB
(130%)
...visual/all-question-types.test.ts-snapshots/select-map-initial-state-webkit.png
Oops, something went wrong.
Binary file modified
BIN
-279 Bytes
(99%)
...ses/visual/all-question-types.test.ts-snapshots/select-map-panning-chromium.png
Oops, something went wrong.
Binary file modified
BIN
-1.25 KB
(98%)
...ases/visual/all-question-types.test.ts-snapshots/select-map-panning-firefox.png
Oops, something went wrong.
Binary file modified
BIN
+12.5 KB
(140%)
...cases/visual/all-question-types.test.ts-snapshots/select-map-panning-webkit.png
Oops, something went wrong.
Binary file modified
BIN
+717 Bytes
(100%)
...visual/all-question-types.test.ts-snapshots/select-map-point-saved-chromium.png
Oops, something went wrong.
Binary file modified
BIN
+860 Bytes
(100%)
.../visual/all-question-types.test.ts-snapshots/select-map-point-saved-firefox.png
Oops, something went wrong.
Binary file modified
BIN
+315 Bytes
(100%)
...s/visual/all-question-types.test.ts-snapshots/select-map-point-saved-webkit.png
Oops, something went wrong.
Binary file modified
BIN
+749 Bytes
(100%)
...ual/all-question-types.test.ts-snapshots/select-map-point-selected-chromium.png
Oops, something went wrong.
Binary file modified
BIN
+736 Bytes
(100%)
...sual/all-question-types.test.ts-snapshots/select-map-point-selected-firefox.png
Oops, something went wrong.
Binary file modified
BIN
+502 Bytes
(100%)
...isual/all-question-types.test.ts-snapshots/select-map-point-selected-webkit.png
Oops, something went wrong.
Binary file modified
BIN
+749 Bytes
(100%)
...-question-types.test.ts-snapshots/select-map-removed-saved-feature-chromium.png
Oops, something went wrong.
Binary file modified
BIN
+746 Bytes
(100%)
...l-question-types.test.ts-snapshots/select-map-removed-saved-feature-firefox.png
Oops, something went wrong.
Binary file modified
BIN
+509 Bytes
(100%)
...ll-question-types.test.ts-snapshots/select-map-removed-saved-feature-webkit.png
Oops, something went wrong.
Binary file modified
BIN
+700 Bytes
(100%)
...isual/all-question-types.test.ts-snapshots/select-map-view-details-chromium.png
Oops, something went wrong.
Binary file modified
BIN
+896 Bytes
(100%)
...visual/all-question-types.test.ts-snapshots/select-map-view-details-firefox.png
Oops, something went wrong.
Binary file modified
BIN
+331 Bytes
(100%)
.../visual/all-question-types.test.ts-snapshots/select-map-view-details-webkit.png
Oops, something went wrong.
Binary file modified
BIN
+683 Bytes
(100%)
...-question-types.test.ts-snapshots/select-map-zoom-current-location-chromium.png
Oops, something went wrong.
Binary file modified
BIN
+1.3 KB
(100%)
...l-question-types.test.ts-snapshots/select-map-zoom-current-location-firefox.png
Oops, something went wrong.
Binary file modified
BIN
-552 Bytes
(99%)
...ll-question-types.test.ts-snapshots/select-map-zoom-current-location-webkit.png
Oops, something went wrong.
Binary file modified
BIN
+2.54 KB
(110%)
...ses/visual/all-question-types.test.ts-snapshots/select-map-zoom-in-chromium.png
Oops, something went wrong.
Binary file modified
BIN
+1.75 KB
(100%)
...ases/visual/all-question-types.test.ts-snapshots/select-map-zoom-in-firefox.png
Oops, something went wrong.
Binary file modified
BIN
+12.2 KB
(130%)
...cases/visual/all-question-types.test.ts-snapshots/select-map-zoom-in-webkit.png
Oops, something went wrong.
Binary file modified
BIN
+1.87 KB
(100%)
...es/visual/all-question-types.test.ts-snapshots/select-map-zoom-out-chromium.png
Oops, something went wrong.
Binary file modified
BIN
-1.59 KB
(99%)
...ses/visual/all-question-types.test.ts-snapshots/select-map-zoom-out-firefox.png
Oops, something went wrong.
Binary file modified
BIN
-254 Bytes
(100%)
...ases/visual/all-question-types.test.ts-snapshots/select-map-zoom-out-webkit.png
Oops, something went wrong.
Binary file modified
BIN
+1.73 KB
(100%)
...estion-types.test.ts-snapshots/select-map-zoom-to-fit-all-features-chromium.png
Oops, something went wrong.
Binary file modified
BIN
+431 Bytes
(100%)
...uestion-types.test.ts-snapshots/select-map-zoom-to-fit-all-features-firefox.png
Oops, something went wrong.
Binary file modified
BIN
+13.9 KB
(120%)
...question-types.test.ts-snapshots/select-map-zoom-to-fit-all-features-webkit.png
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -56,6 +56,12 @@ | |
| --odk-max-image-height: 300px; | ||
| --odk-image-container-size: 300px; | ||
|
|
||
| --odk-spacing-s: 5px; | ||
| --odk-spacing-m: 10px; | ||
| --odk-spacing-l: 15px; | ||
| --odk-spacing-xl: 20px; | ||
| --odk-spacing-xxl: 30px; | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ooh I need this one! :) |
||
|
|
||
| /* | ||
| * This project uses a centralized z-index layering system to manage the stacking order of UI | ||
| * elements, preventing overlap issues and ensuring maintainability. | ||
|
|
@@ -89,6 +95,36 @@ | |
| --odk-z-index-topmost: 1000; | ||
| } | ||
|
|
||
| @mixin toggle-visibility($display: inline-block) { | ||
| /** | ||
| * The "!important" is intentional here. These visibility toggles must strictly enforce their state | ||
| * and override any nested component styles. | ||
| */ | ||
| .desktop-only { | ||
| display: #{$display} !important; | ||
| } | ||
|
|
||
| .mobile-only { | ||
| display: none !important; | ||
| } | ||
|
|
||
| @media screen and (max-width: #{pf.$sm}) { | ||
| .desktop-only { | ||
| display: none !important; | ||
| } | ||
|
|
||
| .mobile-only { | ||
| display: #{$display} !important; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| @mixin sm-constrained { | ||
| @media (width <= #{pf.$sm}) and (orientation: portrait), (height <= #{pf.$sm}) and (orientation: landscape) { | ||
| @content; | ||
| } | ||
| } | ||
|
|
||
| .odk-form { | ||
| @keyframes shimmer { | ||
| 0% { | ||
|
|
@@ -112,23 +148,23 @@ | |
| animation: shimmer 1.5s infinite; | ||
| } | ||
|
|
||
| .desktop-only { | ||
| display: inline; | ||
| } | ||
|
|
||
| .mobile-only { | ||
| display: none; | ||
| } | ||
| @include toggle-visibility(); | ||
| } | ||
|
|
||
| @media screen and (max-width: #{pf.$sm}) { | ||
| .odk-form { | ||
| .desktop-only { | ||
| display: none; | ||
| } | ||
| .odk-form-list { | ||
| margin: 0; | ||
| padding: 0; | ||
| list-style: none; | ||
| overflow: auto; | ||
|
|
||
| .mobile-only { | ||
| display: inline; | ||
| .odk-form-list-item { | ||
| display: block; | ||
| padding: var(--odk-spacing-l) 0; | ||
| width: 100%; | ||
| border: none; | ||
|
|
||
| &:not(:first-child) { | ||
| border-top: 1px solid var(--odk-border-color); | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CSS doesn't support CSS variables in media or container queries. Instead of adding SASS variables, we try to avoid doing so. I considered using mixins instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're on board with using mixins for media or container queries, I'd be happy to open a follow-up PR for that small refactor :)