-
-
Notifications
You must be signed in to change notification settings - Fork 11.1k
[stealth 02/11] Gate identifying features for stealth builds #8786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
reflog
wants to merge
10
commits into
main
Choose a base branch
from
stealth/8764-remove-identifying-features-clean
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
3f922f2
Gate identifying features for stealth builds
reflog f92866a
Address review feedback for stealth feature gates
reflog 6490587
Handle disabled payment route visibly
reflog 128b87a
Localize disabled feature failures
reflog 96c54a2
fix: keep legal support links in stealth builds
reflog a16d73a
fix: gate webview completion callbacks
reflog 6143a0a
docs: document stealth mode boolean alias
reflog f2f4e3f
fix: loosen web payment completion gate
reflog 9020bd1
fix: use no-vpn stealth dart define
reflog 5302aaa
fix: avoid stealth mode build info collision
reflog File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| # Stealth feature gates | ||
|
|
||
| Stealth artifacts disable high-identification product surfaces at compile time | ||
| with Dart environment defines. Normal builds remain unchanged. | ||
|
|
||
| ## Build flags | ||
|
|
||
| Use either profile-style mode names or an explicit boolean flag: | ||
|
|
||
| ```sh | ||
| flutter build apk --dart-define=STEALTH_MODE=stealth-vpn | ||
| flutter build apk --dart-define=STEALTH_MODE=stealth-novpn | ||
| flutter build apk --dart-define=STEALTH_MODE=true | ||
| flutter build apk --dart-define=STEALTH_BUILD=true | ||
| flutter build apk --dart-define=STEALTH_NO_VPN=true | ||
| ``` | ||
|
reflog marked this conversation as resolved.
|
||
|
|
||
| `STEALTH_MODE=true` is kept as a compatibility alias for generic stealth | ||
| artifacts; profile-specific builds should prefer `stealth-vpn` or | ||
| `stealth-novpn`. | ||
|
|
||
| The app derives these gates from the stealth flag: | ||
|
|
||
| - `enableOAuth` | ||
| - `enablePayments` | ||
| - `enableStorePayments` | ||
| - `enableAppLinks` | ||
| - `enableSocialLinks` | ||
| - `enableAutoUpdate` | ||
|
|
||
| `STEALTH_NO_VPN=true` is the explicit no-VPN compatibility flag. It enables the | ||
| same feature gates as `STEALTH_BUILD=true` and is treated as stealth mode even | ||
| when `STEALTH_MODE` is not supplied. | ||
|
|
||
| ## Disabled surfaces | ||
|
|
||
| Stealth builds hide or short-circuit: | ||
|
|
||
| - OAuth login buttons, callbacks, and SSO account deletion verification. | ||
| - Store purchase initialization, restore purchase, Google Play subscription | ||
| management, Stripe/payment redirect entry points, and upgrade CTAs. | ||
| - Runtime app-link handling in Flutter. | ||
| - Follow-us, forum, alternate download, referral/social, and project-link | ||
| surfaces. | ||
| - Desktop auto-update initialization, manual update checks, and appcast URL | ||
| resolution. | ||
|
|
||
| Native manifest and entitlement removal is handled by the stealth manifest | ||
| filtering build step. Artifact leakage checks should still scan final APK/IPA | ||
| and desktop bundles for OAuth provider names, app-link hosts/schemes, billing | ||
| entry points, social URLs, and appcast/update URLs. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.