Skip to content

[stealth 04/11] Add stealth artifact leakage checks#8777

Open
reflog wants to merge 9 commits into
mainfrom
stealth/8766-leakage-checks-v2
Open

[stealth 04/11] Add stealth artifact leakage checks#8777
reflog wants to merge 9 commits into
mainfrom
stealth/8766-leakage-checks-v2

Conversation

@reflog
Copy link
Copy Markdown
Contributor

@reflog reflog commented May 15, 2026

Summary

  • add a configurable stealth leakage scanner for archives and unpacked build output
  • define forbidden-token modes for stealth and stealth-novpn artifacts
  • add Makefile and Android workflow entry points plus scanner docs

Validation

  • python3 -m pytest scripts/stealth/check_leakage_test.py
  • python3 scripts/stealth/check_leakage.py --help
  • git diff --check HEAD~1..HEAD

Closes getlantern/engineering#3570

Copilot AI review requested due to automatic review settings May 15, 2026 12:42
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a configurable Python-based stealth leakage scanner and wires it into Android build tooling so stealth artifacts can be checked for forbidden Lantern/VPN/OAuth/billing/update identifiers.

Changes:

  • Adds forbidden-token configuration with stealth and stealth-novpn modes.
  • Adds scanner implementation and unit tests for directories, archives, allowlists, inheritance, and missing targets.
  • Adds Makefile/workflow entry points and documentation for running leakage checks.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
scripts/stealth/forbidden_tokens.json Defines forbidden token categories and scanner modes.
scripts/stealth/check_leakage.py Implements archive/directory scanning, allowlists, mode resolution, and CLI output.
scripts/stealth/check_leakage_test.py Adds unit tests for core scanner behavior.
Makefile Adds stealth leakage check targets and defaults.
docs/stealth-leakage-checks.md Documents scanner usage, modes, and allowlists.
.github/workflows/build-android.yml Adds optional Android workflow invocation for leakage checks.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/build-android.yml Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Comment thread .github/workflows/build-android.yml Outdated
Comment thread scripts/stealth/check_leakage.py
Comment thread scripts/stealth/check_leakage.py Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Comment thread .github/workflows/build-android.yml
Comment thread .github/workflows/build-android.yml
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Comment thread scripts/stealth/check_leakage.py Outdated
Comment thread .github/workflows/build-android.yml
Comment thread Makefile
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Comment thread scripts/stealth/check_leakage.py
Comment thread scripts/stealth/check_leakage.py Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Comment thread scripts/stealth/check_leakage.py
Comment thread scripts/stealth/check_leakage.py
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Comment thread scripts/stealth/check_leakage.py Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Comment thread scripts/stealth/check_leakage.py Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

@reflog reflog changed the title Add stealth artifact leakage checks [stealth 04/11] Add stealth artifact leakage checks May 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants