fix Android build #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was breaking the Android builds.
Be-ing
changed the title
Be-ing
force-pushed
the
android_build
branch
3 times, most recently
from
a30862b to
7d525de
Compare
Be-ing
force-pushed
the
android_build
branch
from
a5c023b to
6f2fe56
Compare
Author
|
All builds passed!! https://github.com/gethopp/rust-sdks/actions/runs/19526767011/job/55901070695 🎉 |
Be-ing
force-pushed
the
android_build
branch
from
6f2fe56 to
9d01b68
Compare
iparaskev
added a commit
that referenced
this pull request
Dec 5, 2025
* feat: expose DesktopCapturer
Implements screen sharing by exposing libwebrtc's
DesktopCapturer.
A few platform specific notes:
- macos:
* It is using screen capture kit and the system picker by
default. If the system picker is disabled then get_sources
returns an empty list when trying to capture a display. The
display native id needs to be acquired using different means
from the client.
- linux:
* With pipewire the only way to select window or display is via
the system picker.
* use pkg-config to find Linux libraries (#2)
* Support x11 dependencies
* Modify example to work on x11
* Address comments
* Properly guard sck options
* Address review comments
In particular:
- Adds support for the generic capturer.
- Exposes the desktop_capturer module only on macos, linux and
windows.
- Updates the example
* Update license
* Set callback on start
* Make the callback FnMut
* cpp formatting
* Allow disabling system picker in example
* Address review comments
* Remove reference to temporary
* Run screen-sharing example only on supported platforms
* cargo fmt
* Update build runner with DesktopCapturer deps on linux
* Update runner
* Update tests runner
* fix Android build (#7)
* screensharing example: remove rustls-native feature from livekit
This was breaking the Android builds.
* improve error handling for File::open
* webrtc-sys-build: skip parsing desktop_capture.ninja on Android
* webrtc-sys-build: bump prebuilt library to webrtc-0001d84-2
* Enable TLS features for the screenshare example
---------
Co-authored-by: Be <be.0@gmx.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was breaking the Android builds.
Test run here: https://github.com/Be-ing/rust-sdks/actions/runs/19513878739/job/55860406639