This repository was archived by the owner on Sep 28, 2024. It is now read-only.
Spec incompliance: the truth of the error object should not depend on… #45
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the code being non 0. According to the JSON_RPC v2.0 specs (http://www.jsonrpc.org/specification), the error response should contain an 'error' object which has at least 'code' and 'message' objects, hence the truth of the error object should depend on their existence. Although not an optimum selection, 0 is not disallowed as error code. Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Author
|
@gerold-penz have you seen this PR? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… the code being non 0.
According to the JSON_RPC v2.0 specs (http://www.jsonrpc.org/specification),
the error response should contain an 'error' object which has at
least 'code' and 'message' objects, hence the truth of the error
object should depend on their existence. Although not an optimum
selection, 0 is not disallowed as error code.
Signed-off-by: Konstantina Chremmou konstantina.chremmou@citrix.com