Saved map resolutions and aligned with custom resolutions and projection of map#12443
Open
subashtiwari1010 wants to merge 2 commits into
Open
Saved map resolutions and aligned with custom resolutions and projection of map#12443subashtiwari1010 wants to merge 2 commits into
subashtiwari1010 wants to merge 2 commits into
Conversation
…s MapStore causing OOM if resolutions configured in new.json file with a different projection (geosolutions-it#11788)" (geosolutions-it#11821) This reverts commit f337dbb.
1 task
99488fe to
07262e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR reapplies the reverted fix from #11821, which prevents map freezes and OOM errors when the CRS changes while saved resolutions still belong to another projection. It also moves custom resolutions to per-CRS configuration in CRSSelector, so the CRS and its resolutions stay aligned when switching projections and when saving the map.
Changes
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
The OOM behavior happens if the resolutions and projection are provided in
new.jsonfile and user switch to different projection rather than the resolutions one.#11779 (comment)
What is the new behavior?
When you change the map CRS, the custom resolutions configured for that CRS in CRSSelector is applied (or computes them if it is not set) and saves them with the map so they stay aligned on reload.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information