make Nominatim host and protocol configurable via search service options#12316
make Nominatim host and protocol configurable via search service options#12316jwkaltz wants to merge 4 commits into
Conversation
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Wolfgang Kaltz.
|
|
@jwkaltz Thank you so much for this! |
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Wolfgang Kaltz.
|
Hi @tdipisa , thanks for the link to the CLA! I have now sent it via email. |
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Wolfgang Kaltz.
|
ca57ce9 to
4da9619
Compare
4da9619 to
bbda876
Compare
Description
Restructure nominatim URL construction in order to make hostname and protocol overrideable.
Add tests for Nominatim.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
The Nominatim geocoding endpoint is currently hardcoded as
https://nominatim.openstreetmap.orginweb/client/api/nominatim.js.This prevents users from configuring a custom Nominatim instance, which is required for:
What is the new behavior?
Read
hostandprotocolfrom the serviceoptionsobject, falling back to the current defaults if not provided. This is fully backwards compatible — existing configurations continue to work unchanged.Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information
After this change, there will be more options in
localConfig.jsonor viaoverrideLocalConfig:{ "type": "nominatim", "priority": 5, "options": { "host": "my-nominatim.example.com", "protocol": "https", "limit": 10, "polygon_geojson": 1 } }