-
Notifications
You must be signed in to change notification settings - Fork 444
configurable Search plugin layout menu #11581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
configurable Search plugin layout menu #11581
Conversation
jsdoc new option
f839906 to
361b4d2
Compare
|
@stefanocudini The changes in layout seems okay. One thing that I find missing is relevant test case . Can you add a related test to check if the class or layout is correct when the property Something like |
anup39
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@ElenaGallo please test this new configuration on dev, thanks |
|
Successfully created backport PR for |
|
@ElenaGallo let us know for the backport, please. |
|
Test passed on DEV, @allyoucanmap backport can be merged here: #11808 |
Description
Fix issue #11546
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
All custom services are show only to the side menu introduced here: #11144
What is the new behavior?
This new option for plugin Search in localConfig:
cfg.searchOptions.bottomMenuServices(default false to maintain old config)if
trueallows you to move the side menu below the main menu, keeping it at the same level. Vertical scrolling is maintained for very long lists.search_new_layout.mp4
Breaking change
No.
one style Less class added this preserve compatibility with old themes 'search-services-submenus-bottom`
Other useful information
localConfig in section
plugins.desktop, example to enable feature working with public GS:{ "name": "Search", "cfg": { "searchOptions": { "bottomMenuServices": true, "services": [ { "type": "wfs", "name": "US States", "displayName": "${properties.state_name}", "subTitle": "level: mapstore:states", "priority": 1, "options": { "url": "https://gs-stable.geo-solutions.it/geoserver/wfs", "typeName": "mapstore:states", "queriableAttributes": [ "state_name" ], "sortBy": "", "maxFeatures": 5 } }, { "type": "wfs", "name": "Cleveland Metro Trails", "displayName": "${properties.name}", "subTitle": "level: clevelandmetro:cm_regional_trails_with_routes", "priority": 1, "options": { "url": "https://gs-stable.geo-solutions.it/geoserver/wfs", "typeName": "clevelandmetro:cm_regional_trails_with_routes", "queriableAttributes": [ "name" ], "sortBy": "", "maxFeatures": 5 } } ] } } }