Skip to content

Fix the developer page not having perPageOptions despite being implemented in server. #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Chs000-00 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix the developer page not having perPageOptions despite being implemented in server. #93

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 25 additions & 1 deletion src/routes/developers/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
import Search from "$lib/components/Search.svelte";
import { clamp } from "$lib/api/helpers";
import Pagination from "$lib/components/Pagination.svelte";
import Select from "$lib/components/Select.svelte";
import SelectOption from "$lib/components/SelectOption.svelte";
import DeveloperCard from "$lib/components/DeveloperCard.svelte";
import LoadingCircle from "$lib/components/LoadingCircle.svelte";

Expand All @@ -23,6 +25,8 @@
let max_count = $derived(data.developers?.count ?? 0);
let max_page = $derived(Math.floor(max_count / per_page) + 1);
let searching = $state(false);

const perPageOptions = [10, 15, 20];

const updateParams = async () => {
const params = new URLSearchParams();
Expand Down Expand Up @@ -81,7 +85,27 @@
disabled={!data.developers}
label="developers"
labelOne="developer"
select={(page) => gotoPage(page)} />
select={(page) => gotoPage(page)}>
<Select
title="Per page"
titleIcon="eye"
select={(value) => {
const newValue = parseInt(value);
if (per_page !== newValue) {
per_page = newValue;
updateParams();
}
}}>
{#each perPageOptions as option}
<SelectOption
icon="right"
title={option.toString()}
value={option.toString()}
isDefault={option === per_page} />
{/each}
</Select>
</Pagination>

<ul class="developer-list">
{#if searching}
<div class="loading">
Expand Down