[Pelias][OpenRouteService][GeocodeEarth] Fix admin level ordering#1202
Closed
mrbig wants to merge 5 commits intogeocoder-php:masterfrom
Closed
[Pelias][OpenRouteService][GeocodeEarth] Fix admin level ordering#1202mrbig wants to merge 5 commits intogeocoder-php:masterfrom
mrbig wants to merge 5 commits intogeocoder-php:masterfrom
Conversation
Order of the adminLeves in Pelias did not have any particular order. I have changed the order according to this ticket: geocoder-php#852 Please note that this might be a breaking change for someone.
AdminLevels are now ordered according to the following principles geocoder-php#852
AdminLevels are now ordered according to the following principles geocoder-php#852
mrbig
changed the title
Author
|
I have noticed that there are two other providers that use the Pelias provider. That means that this change affects those as well. I have update their unit tests. I'm not sure if such a change is acceptable by your policy. This can be considered as a bugfix but also a breaking change. |
norkunas
reviewed
Oct 26, 2023
norkunas
reviewed
Oct 26, 2023
norkunas
reviewed
Oct 26, 2023
Using assertSame instead of assertEquals
Member
|
I've been working on an improvement for Pelias provider and I've included a refactoring of the admin levels extraction in #1250. |
Author
Author
Member
|
Superseded by #1250 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Order of the adminLeves in Pelias did not have any particular order. I have changed the order according to this ticket: #852
Please note that this might be a breaking change for someone.