Skip to content

PB-2064: print cypress test#1532

Merged
pakb merged 11 commits intofeat-PB-1383-pinia-storefrom
fix-pb-2064-print
Jan 29, 2026
Merged

PB-2064: print cypress test#1532
pakb merged 11 commits intofeat-PB-1383-pinia-storefrom
fix-pb-2064-print

Conversation

@sommerfe
Copy link
Copy Markdown
Contributor

@sommerfe sommerfe commented Dec 9, 2025 •
edited by github-actions Bot
Loading

@sommerfe sommerfe self-assigned this Dec 9, 2025
@github-actions github-actions Bot added the bug label Dec 9, 2025
@cypress
Copy link
Copy Markdown

cypress Bot commented Dec 9, 2025 •
edited
Loading

web-mapviewer    Run #6423

Run Properties:  status check failed Failed #6423  •  git commit 34e830f269: PB-2064: revert separation of OL in the bunlder
Project web-mapviewer
Branch Review fix-pb-2064-print
Run status status check failed Failed #6423
Run duration 19m 22s
Commit git commit 34e830f269: PB-2064: revert separation of OL in the bunlder
Committer Pascal Barth
View all properties for this run ↗︎
Test results
Tests that failed  Failures 18
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 5
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 251
View all changes introduced in this branch ↗︎

Tests for review

Failed  drawing.cy.ts • 13 failed tests • e2e/chrome/mobile

View Output

Test Artifacts
Drawing module tests > Drawing mode/tools > can create marker/icons and edit them Test Replay Screenshots
Drawing module tests > Drawing mode/tools > can create line / measurement, extend it, and delete the last node by right click / button, and make a polygon Test Replay Screenshots
Drawing module tests > Drawing mode/tools > can create line/polygons and edit them Test Replay Screenshots
Drawing module tests > KML management > deletes the drawing when confirming the delete modal Test Replay Screenshots
Drawing module tests > KML management > manages the KML layer in the layer list / URL params correctly Test Replay Screenshots
Drawing module tests > KML management > keeps the KML after a page reload, and creates a copy if it is then edited Test Replay Screenshots
Drawing module tests > KML management > manages the KML layer correctly if it comes attached with an adminId at startup Test Replay Screenshots
Drawing module tests > KML management > manages the KML layer correctly if it comes attached with an adminId at startup from a legacy URL Test Replay Screenshots
Drawing module tests > KML management > receives an empty KML and can use drawing mode Test Replay Screenshots
Drawing module tests > others > can export the drawing/profile in multiple formats Test Replay Screenshots
The first 10 failed tests are shown, see all 13 tests in Cypress Cloud.
Failed  featureSelection.cy.ts • 4 failed tests • e2e/chrome/mobile

View Output

Test Artifacts
Testing the feature selection > Feature pre-selection in the URL > Synchronise URL and feature selection Test Replay Screenshots
Testing the feature selection > Feature identification on the map > can select an area to identify features inside it Test Replay Screenshots
Testing the feature selection > Feature identification on the map > can select feature by click, add more feature, and deselect feature Test Replay Screenshots
Testing the feature selection > Feature identification on the map > can print feature information Test Replay Screenshots
Failed  importToolMaps.cy.ts • 1 failed test • e2e/chrome/mobile

View Output

Test Artifacts
The Import Maps Tool > Import external WMTS layers Test Replay Screenshots

@sommerfe sommerfe force-pushed the fix-pb-2064-print branch 4 times, most recently from 31a1e57 to 1c3117c Compare December 15, 2025 07:43
@sommerfe sommerfe changed the base branch from feat-PB-1383-pinia-store to fix-pb-2026-fix-import-tool-file December 15, 2025 07:44
@ismailsunni ismailsunni force-pushed the fix-pb-2026-fix-import-tool-file branch from 313b278 to 06578d8 Compare December 16, 2025 02:56
Felix Sommer and others added 8 commits January 23, 2026 08:18
@pakb
PB-2064: fix print types
4a60814
@pakb
PB-2064: fix print orientation current highlight
c59c074
@pakb
PB-2064: fix opacity on print layers
1d70220
@pakb
PB-2064: fix print providers sorting
60e36a4
@pakb
PB-2064: move print stuff back into viewer package
50ac157 
there are some issue with @geoblocks/mapfishprint not sharing the same instance of OpenLayers than the rest of the code, leading to some false negative with "instanceof" operator.

It is testing against ol/style/Image and ol/style/Circle, but doesn't use the same reference than our code, leading to always false results.

I've added a patch to the lib to fix that
@pakb
PB-2064: moving OL bundle to dedicated file
23e654e 
and trying to share the same OL "code" throughout the code-base (when imported into the viewer package)

Also changing vite aliases with a simpler way of aliasing '@' that isn't using a URL anymore.
@pakb
PB-2064: removing tailwind class prefix
2a8b459 
I had some issue with important not being applied (being second in line), and after testing without the prefix it was working as intended (so no need to add complexity there)
@pakb
PB-2064: fix print test
78b1cf4
@pakb pakb force-pushed the fix-pb-2064-print branch from 1b6683a to 16baf99 Compare January 28, 2026 15:23
@pakb pakb changed the base branch from fix-pb-2026-fix-import-tool-file to feat-PB-1383-pinia-store January 28, 2026 15:24
@pakb pakb force-pushed the fix-pb-2064-print branch from 7cca003 to 7218dce Compare January 28, 2026 16:33
@pakb
PB-2064: revert separation of OL in the bunlder
34e830f 
creates more issue that it solves
@pakb pakb force-pushed the fix-pb-2064-print branch from 2cb6b93 to 34e830f Compare January 29, 2026 07:38
@pakb pakb merged commit 8515ccf into feat-PB-1383-pinia-store Jan 29, 2026
4 of 6 checks passed
@pakb pakb deleted the fix-pb-2064-print branch January 29, 2026 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sommerfe sommerfe

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sommerfe @pakb