-
Notifications
You must be signed in to change notification settings - Fork 3
NOD-391: Update workflow to handle renamed GenLayer chain config variables #280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
✅ Deploy Preview for genlayer-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Join our Discord community for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
AgustinRamiroDiaz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good, we cannot merge until node v0.4 is released
AgustinRamiroDiaz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please rebase this branch
…ables Only update the sync workflow script to handle the new variable names. Documentation files will be auto-updated when the release is created. Co-Authored-By: Agustín Díaz <agustin.ramiro.diaz@gmail.com>
bbea6d6 to
0c22145
Compare
Description
This PR implements ticket NOD-391 to rename misleading zkSync configuration variables that actually point to GenLayer chain endpoints, not zkSync endpoints. The changes improve clarity and prevent confusion by using more accurate naming throughout the codebase.
Link to Devin run: https://app.devin.ai/sessions/309d3e633b1447a88164d1745bf5dbfa
Requested by: @AgustinRamiroDiaz
This is a breaking change that requires users to update their configuration files:
Before:
After:
Changes Made
Go Code Updates
ZkSyncURL→GenlayerChainRpcURLandZkSyncWebSocketURL→GenlayerChainWebSocketURLinRollupConfigstructyaml:"zksyncurl"→yaml:"genlayerchainrpcurl"andyaml:"zksyncwebsocketurl"→yaml:"genlayerchainwebsocketurl"connect.goand other filesinternal.goConfiguration Files
configs/node/config.yaml.examplewith new variable namesCI/CD & Deployment
.github/workflows/release-package.ymlto use new variable namesGENLAYERNODE_ROLLUP_ZKSYNC_URL→GENLAYERNODE_ROLLUP_GENLAYERCHAIN_RPC_URLDocumentation
Files changed: 24 files with 87 insertions and 87 deletions
Human Review Checklist
Critical items to verify:
go build)GenlayerChainRpcURLnotGenlayerChainRPCURL)taskfiles/handle the new variable names correctlyTesting suggestions:
Migration considerations:
Risk Assessment
The extensive scope of this rename requires careful verification to ensure no references were missed and that all systems continue to function correctly.