fix(workflows): Fix Python script execution in sync-docs-from-node workflow #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for genlayer-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
Caution Review failedThe pull request is closed. WalkthroughThis update deletes the documentation file for the v0.3.4 validator release, introduces a standalone Python script to sanitize GenLayer node configuration files, and modifies a GitHub Actions workflow to use this external script instead of an inline Python command for YAML sanitization. Changes
Sequence Diagram(s)sequenceDiagram
participant Workflow
participant Script
participant ConfigFile
Workflow->>Script: Call sanitize-config.py with config.yaml
Script->>ConfigFile: Read config.yaml
Script->>ConfigFile: Remove node.dev and node.admin sections
Script->>ConfigFile: Write sanitized config.yaml
Script-->>Workflow: Return control
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
…rkflow This PR fixes a critical issue in the sync-docs-from-node workflow where the Python script for sanitizing config files was failing due to an environment variable not being accessible. The inline Python code has been refactored into a standalone script that receives the config file path as a command-line argument.
dohernandez
force-pushed
the
chore/nod-189-ci-automate-changelog
branch
from
6f44512 to
7103934
Compare
8 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(workflows): Fix Python script execution in sync-docs-from-node workflow
Description
This PR fixes a critical issue in the sync-docs-from-node workflow where the Python script for sanitizing config files was failing due to an environment variable not being accessible. The inline Python code has been refactored into a standalone script that receives the config file path as a command-line argument.
Summary by CodeRabbit